Fast-forward master #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we are installing a requested version now, it shouldn't be necessary to filter by the release version string when searching for the node binary. Meteor has the habit of installing the next patch release even when you request an older one (e.g. it interprets ?release=1.1.0.3 as ^1.1.0).
Support for Meteor 1.4, faster compilation, caching
Users can still install mongolab manually -- and that's what the usage instructions have always advised anyway. Removing it from bin/release allows non-mongolab users to use this buildpack without forking.
Instead of trying to install and maintain a single release of version only, allow meteor to do what it really wants, which is to have multiple releases installed at once. Install the latest from install.meteor.com, and allow meteor to upgrade/downgrade itself as per the project .meteor/release target. Both/all versions of meteor will persist in the build cache, so subsequent builds with the same release target should still be speedy. Identify the version of node/npm to use by asking node itself, using "meteor node -c 'process.stdout.write(process.execPath)'". That way, we get the correct node version even if multiple simultaneous versions exist. This ought to address issues #132, #138, #145, #146.
Also fixes missing '-' in arrow.
Perform cache clearing after build
Ability to set additional node parameters
Use the published version of the buildpack from the registry.
Update README.md
Fix clear cache flag checking
It not defined -> If not defined
Fix typo in README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is