feat (48829): agent stuff updates #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
maryjanyes
commented
Oct 21, 2024
•
maryjanyes
commented
- Add ability for admin to add user's identity to the registry. #83
- When pasting the address into "add agent" input #84
- Cleanup duplicate values from "select address which was already in use" #85
Signed-off-by: maryjanyes <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
👷 Deploy Preview for swirlds-eip processing.
|
✅ Deploy Preview for swirlds-eip ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
dchernokur
requested changes
Oct 21, 2024
dchernokur
requested changes
Oct 21, 2024
| const accountIdentity = identityItems.find( | ||
| (item) => item.wallet === accountEvm, | ||
| ); | ||
| const isAccountAgentAdmin = filteredNotAgentsYet?.includes( |
There was a problem hiding this comment.
why are we sure that having a record here makes a user an Admin? Maybe user was removed afterwards? Is there a reliable way to detect Agent vs Admin?
There was a problem hiding this comment.
why are we sure that having a record here makes a user an Admin? Maybe user was removed afterwards? Is there a reliable way to detect Agent vs Admin?
Admin is the one who can perform edit operations, because of it Agent became Admin and Admin also became Agent. Correct me if i wrong @dchernokur.
dchernokur
requested changes
Oct 21, 2024
dchernokur
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.