[BUGFIX] Working with glossary without a request not possible #375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calien666
requested review from
NarkNiro and
sbuerk
and removed request for
NarkNiro
calien666
force-pushed
the
bugfix/glossary-sync-without-request
branch
from
7f5dde5 to
f0c5fba
Compare
The DeeplBackendUtility tried to detect the current working page by guessing the page id via the global request. In some cases no request is given, like on CLI calls. Avoiding errors not using the glossary when not calling translation via backend, a new service `ProcessingInstruction` is added, saving the current instructions inside the global runtime cache. This information can now get detected in every point of the translation and allows a correct detection of the current working page including a valid glossary, if one exists. A regression test is added demonstrating the glossary is now detected and respected, even if no request is set up.
calien666
force-pushed
the
bugfix/glossary-sync-without-request
branch
from
f0c5fba to
cc62452
Compare
sbuerk
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The DeeplBackendUtility tried to detect the current working page by guessing the page id via the global request. In some cases no request is given, like on CLI calls. Avoiding errors not using the glossary when not calling translation via backend, a new service
ProcessingInstructionis added, saving the current instructions inside the global runtime cache. This information can now get detected in every point of the translation and allows a correct detection of the current working page including a valid glossary, if one exists.A regression test is added demonstrating the glossary is now detected and respected, even if no request is set up.