Jws narayana tests #41
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PLEASE NOTE THAT THIS PR is not intended to be merged, but rather to discuss if the current jws-narayana-tests should be "force-pushed" from sgala/jws-narayana-tests.
Rebase the branch to current master.
The commits in this PR are what remains of the changes. The changes in the commit to ensure jwk17 compatibility were already in master.
I tested our jws job and the rebased branch runs the tests correctly. Re: the current master, h2 tests pass but postgresql tests fail, due to "DataSource not found in JNDI." So the commit changing to ""javax.sql.XADataSource"" in this PR is needed, not sure about the other one.