DOM: Don't use dependent AbortSignals for Observable Subscribers #47074
+160
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This CL introduces subtle timing differences in Subscriber abortion and teardown execution, across Subscribers in a chain of Observables. These timing differences are the result of no longer using the DOM Standard's dependent AbortSignal concept for Observables that are chained together. For a full description of this change, see WICG/observable#154. Bug: 40282760 Change-Id: I4feb6f9ad67e2dd7d7a4d5ec51fdecebc4e6ae18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5676226 Reviewed-by: Joey Arhar <[email protected]> Commit-Queue: Dominic Farolino <[email protected]> Cr-Commit-Position: refs/heads/main@{#1325506}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-5676226
branch
from
064e9ac to
a7c7ab8
Compare
wpt-pr-bot
approved these changes
Jul 10, 2024
|
Confirmed that this looks correct (despite the fact it's already merged), attn: @domfarolino |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CL introduces subtle timing differences in Subscriber abortion and
teardown execution, across Subscribers in a chain of Observables. These
timing differences are the result of no longer using the DOM Standard's
dependent AbortSignal concept for Observables that are chained together.
For a full description of this change, see
WICG/observable#154.
Bug: 40282760
Change-Id: I4feb6f9ad67e2dd7d7a4d5ec51fdecebc4e6ae18
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5676226
Reviewed-by: Joey Arhar <[email protected]>
Commit-Queue: Dominic Farolino <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1325506}