Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close the dialog element when the open attribute is removed #44408

Merged
merged 1 commit into from
Feb 9, 2024

Close the dialog element when the open attribute is removed

487ed05
Select commit
Loading
Failed to load commit list.
Merged

Close the dialog element when the open attribute is removed #44408

Close the dialog element when the open attribute is removed
487ed05
Select commit
Loading
Failed to load commit list.
Community-TC Integration / wpt-chrome-dev-results succeeded Feb 9, 2024 in 9m 56s

Community-TC (pull_request)

Collect results for all tests affected by a pull request in chrome.

Details

View task in Taskcluster
View logs in Taskcluster

WPT Command: python3 ./wpt run --channel=dev --no-fail-on-unexpected --log-wptreport=../artifacts/wpt_report.json --log-wptscreenshot=../artifacts/wpt_screenshot.txt --affected base_head --log-mach-level=info --log-mach=- -y --no-pause --no-restart-on-unexpected --install-fonts --no-headless --verify-log-full --enable-swiftshader --install-browser --install-webdriver chrome

Failed to read: session.colorsPerChannel
Setting default value
Failed to read: session.doubleClickInterval
Setting default value
Failed to read: session.tabPadding
Setting default value
Failed to read: session.styleOverlay
Setting default value
Failed to read: session.slitlistFile
Setting default value
Failed to read: session.appsFile
Setting default value
Failed to read: session.tabsAttachArea
Setting default value
Failed to read: session.cacheLife
Setting default value
Failed to read: session.cacheMax
Setting default value
Failed to read: session.autoRaiseDelay
Setting default value
Failed to read: session.screen0.opaqueMove
Setting default value
Failed to read: session.screen0.fullMaximization
Setting default value
Failed to read: session.screen0.maxIgnoreIncrement
Setting default value
Failed to read: session.screen0.maxDisableMove
Setting default value
Failed to read: session.screen0.maxDisableResize
Setting default value
Failed to read: session.screen0.workspacewarping
Setting default value
Failed to read: session.screen0.showwindowposition
Setting default value
Failed to read: session.screen0.autoRaise
Setting default value
Failed to read: session.screen0.clickRaises
Setting default value
Failed to read: session.screen0.defaultDeco
Setting default value
Failed to read: session.screen0.tab.placement
Setting default value
Failed to read: session.screen0.windowMenu
Setting default value
Failed to read: session.screen0.noFocusWhileTypingDelay
Setting default value
Failed to read: session.screen0.workspaces
Setting default value
Failed to read: session.screen0.edgeSnapThreshold
Setting default value
Failed to read: session.screen0.window.focus.alpha
Setting default value
Failed to read: session.screen0.window.unfocus.alpha
Setting default value
Failed to read: session.screen0.menu.alpha
Setting default value
Failed to read: session.screen0.menuDelay
Setting default value
Failed to read: session.screen0.tab.width
Setting default value
Failed to read: session.screen0.tooltipDelay
Setting default value
Failed to read: session.screen0.allowRemoteActions
Setting default value
Failed to read: session.screen0.clientMenu.usePixmap
Setting default value
Failed to read: session.screen0.tabs.usePixmap
Setting default value
Failed to read: session.screen0.tabs.maxOver
Setting default value
Failed to read: session.screen0.tabs.intitlebar
Setting default value
Failed to read: session.screen0.focusModel
Setting default value
Failed to read: session.screen0.tabFocusModel
Setting default value
Failed to read: session.screen0.focusNewWindows
Setting default value
Failed to read: session.screen0.focusSameHead
Setting default value
Failed to read: session.screen0.rowPlacementDirection
Setting default value
Failed to read: session.screen0.colPlacementDirection
Setting default value
Failed to read: session.screen0.windowPlacement
Setting default value
Failed to read: session.screen0.slit.acceptKdeDockapps
Setting default value
Failed to read: session.screen0.slit.autoHide
Setting default value
Failed to read: session.screen0.slit.maxOver
Setting default value
Failed to read: session.screen0.slit.placement
Setting default value
Failed to read: session.screen0.slit.alpha
Setting default value
Failed to read: session.screen0.slit.onhead
Setting default value
Failed to read: session.screen0.slit.layer
Setting default value
Failed to read: session.screen0.toolbar.autoHide
Setting default value
Failed to read: session.screen0.toolbar.maxOver
Setting default value
Failed to read: session.screen0.toolbar.visible
Setting default value
Failed to read: session.screen0.toolbar.alpha
Setting default value
Failed to read: session.screen0.toolbar.layer
Setting default value
Failed to read: session.screen0.toolbar.onhead
Setting default value
Failed to read: session.screen0.toolbar.placement
Setting default value
Failed to read: session.screen0.toolbar.height
Setting default value
Failed to read: session.screen0.iconbar.mode
Setting default value
Failed to read: session.screen0.iconbar.alignment
Setting default value
Failed to read: session.screen0.iconbar.iconWidth
Setting default value
Failed to read: session.screen0.iconbar.iconTextPadding
Setting default value
Failed to read: session.screen0.iconbar.usePixmap
Setting default value
 0:08.70 INFO Identified 2 affected tests
 0:08.70 INFO Installing browser
 0:08.75 INFO Downloading Chrome for Testing from https://edgedl.me.gvt1.com/edgedl/chrome/chrome-for-testing/123.0.6286.0/linux64/chrome-linux64.zip
mem avail: 14783 of 15806 MiB (93 %), swap free:    0 of    0 MiB ( 0 %)
 0:23.45 INFO Downloading Mojo bindings from https://storage.googleapis.com/chrome-wpt-mojom/123.0.6286.0/linux64/mojojs.zip
 0:23.51 INFO MojoJS enabled automatically (mojojs_path: /home/test/web-platform-tests/_venv3/mojojs/gen)
 0:23.54 INFO Download info for matching ChromeDriver version found.
 0:23.54 INFO Downloading ChromeDriver from https://edgedl.me.gvt1.com/edgedl/chrome/chrome-for-testing/123.0.6286.0/linux64/chromedriver-linux64.zip
 0:23.88 INFO Automatically turning on experimental features for Chrome Dev/Canary or Chromium trunk
 0:29.04 INFO Installed font: Ahem.ttf
 0:29.87 wptserve INFO Starting http server on http://127.0.0.1:8000
 0:29.90 wptserve INFO Starting http server on http://127.0.0.1:8001
 0:29.94 wptserve INFO Starting https server on https://127.0.0.1:8445
 0:29.94 wptserve INFO Starting http server on http://127.0.0.1:8003
 0:29.94 wptserve INFO Starting http server on http://127.0.0.1:8002
 0:29.96 wptserve INFO Starting https server on https://127.0.0.1:8444
 0:29.98 wptserve INFO Create socket on: (<AddressFamily.AF_INET: 2>, <SocketKind.SOCK_STREAM: 1>, 6, '', ('127.0.0.1', 8888))
 0:29.98 wptserve INFO Bind on: (<AddressFamily.AF_INET: 2>, <SocketKind.SOCK_STREAM: 1>, 6, '', ('127.0.0.1', 8888))
 0:29.98 wptserve INFO Listen on: (<AddressFamily.AF_INET: 2>, <SocketKind.SOCK_STREAM: 1>, 6, '', ('127.0.0.1', 8888))
 0:29.99 wptserve INFO Starting https server on https://127.0.0.1:8443
 0:30.01 wptserve INFO Create socket on: (<AddressFamily.AF_INET: 2>, <SocketKind.SOCK_STREAM: 1>, 6, '', ('127.0.0.1', 8889))
 0:30.01 wptserve INFO Bind on: (<AddressFamily.AF_INET: 2>, <SocketKind.SOCK_STREAM: 1>, 6, '', ('127.0.0.1', 8889))
 0:30.01 wptserve INFO Listen on: (<AddressFamily.AF_INET: 2>, <SocketKind.SOCK_STREAM: 1>, 6, '', ('127.0.0.1', 8889))
 0:30.01 wptserve INFO Starting https server on https://127.0.0.1:8446
 0:30.03 wptserve INFO Starting http2 server on https://127.0.0.1:9000
 0:30.08 wptserve INFO Starting WebTransport over HTTP/3 server on 127.0.0.1:11000
 0:30.86 SUITE_START: web-platform-test - running 2 tests
 0:36.97 INFO Using 1 child processes
 0:37.48 pid:2171 Full command: /home/test/web-platform-tests/_venv3/bin/chrome/chromedriver --port=52007 --url-base=/ --enable-chrome-logs --disable-build-check
pid:2171 Starting ChromeDriver 123.0.6286.0 (e6d7ff21a359ae267331f436f6f3c68c752bf87b-refs/branch-heads/6286@{#1}) on port 52007
 0:37.48 pid:2171 Only local connections are allowed.
 0:37.48 pid:2171 Please see https://chromedriver.chromium.org/security-considerations for suggestions on keeping ChromeDriver safe.
 0:37.48 pid:2171 ChromeDriver was started successfully.
 0:37.48 INFO Starting runner
 0:37.81 pid:2171 [2183:2183:0209/185740.756114:WARNING:chrome_main_delegate.cc(742)] This is Chrome version 123.0.6286.0 (not a warning)
 0:38.19 pid:2171 [2183:2183:0209/185741.135421:INFO:policy_logger.cc(145)] :components/policy/core/common/config_dir_policy_loader.cc(118) Skipping mandatory platform policies because no policy file was found at: /etc/opt/chrome_for_testing/policies/managed
 0:38.19 pid:2171 [2183:2183:0209/185741.135448:INFO:policy_logger.cc(145)] :components/policy/core/common/config_dir_policy_loader.cc(118) Skipping recommended platform policies because no policy file was found at: /etc/opt/chrome_for_testing/policies/recommended
 0:38.19 pid:2171 [2183:2183:0209/185741.137073:WARNING:field_trial_util.cc(105)] Field trial config study skipped: CookieSameSiteConsidersRedirectChainDesktop.Enabled (some of its features are already overridden)
 0:38.19 pid:2171 [2183:2183:0209/185741.137772:WARNING:field_trial_util.cc(105)] Field trial config study skipped: PendingBeaconAPI.EnabledOnlyForOriginTrial (some of its features are already overridden)
 0:38.74 pid:2171 [2183:2183:0209/185741.692329:ERROR:policy_logger.cc(157)] :components/enterprise/browser/controller/chrome_browser_cloud_management_controller.cc(161) Cloud management controller initialization aborted as CBCM is not enabled. Please use the `--enable-chrome-browser-cloud-management` command line flag to enable it if you are not using the official Google Chrome build.
 0:38.80 pid:2171 
 0:38.80 pid:2171 DevTools listening on ws://127.0.0.1:35787/devtools/browser/8eddb483-4f8c-46c6-a820-418d72b88c68
 0:38.81 pid:2171 [2217:2217:0209/185741.754648:WARNING:gpu_memory_buffer_support_x11.cc(49)] dri3 extension not supported.
 0:38.81 pid:2171 [2217:2217:0209/185741.757194:WARNING:sandbox_linux.cc(418)] InitializeSandbox() called with multiple threads in process gpu-process.
Failed to read: session.screen0.titlebar.left
Setting default value
Failed to read: session.screen0.titlebar.right
Setting default value
 0:38.89 pid:2171 [2183:2183:0209/185741.833995:WARNING:bluez_dbus_manager.cc(248)] Floss manager not present, cannot set Floss enable/disable.
 0:38.90 pid:2171 [1707505061.842][WARNING]: You are using an unsupported command-line switch: --disable-build-check. Please don't report bugs that cannot be reproduced with this switch removed.
 0:38.92 pid:2171 [2183:2279:0209/185741.866740:ERROR:object_proxy.cc(576)] Failed to call method: org.freedesktop.DBus.Properties.Get: object_path= /org/freedesktop/UPower: org.freedesktop.DBus.Error.ServiceUnknown: The name org.freedesktop.UPower was not provided by any .service files
 0:38.92 pid:2171 [2183:2279:0209/185741.867605:WARNING:property.cc(144)] DaemonVersion: GetAndBlock: failed.
 0:38.92 pid:2171 [2183:2279:0209/185741.870328:ERROR:object_proxy.cc(576)] Failed to call method: org.freedesktop.UPower.GetDisplayDevice: object_path= /org/freedesktop/UPower: org.freedesktop.DBus.Error.ServiceUnknown: The name org.freedesktop.UPower was not provided by any .service files
 0:38.92 pid:2171 [2183:2279:0209/185741.871336:ERROR:object_proxy.cc(576)] Failed to call method: org.freedesktop.UPower.EnumerateDevices: object_path= /org/freedesktop/UPower: org.freedesktop.DBus.Error.ServiceUnknown: The name org.freedesktop.UPower was not provided by any .service files
 0:38.93 pid:2171 [2183:2183:0209/185741.875204:WARNING:idle_linux.cc(105)] None of the known D-Bus ScreenSaver services could be used.
 0:39.63 TEST_START: /html/semantics/interactive-elements/the-dialog-element/dialog-close-via-attribute.html
 0:39.87 TEST_END: Test OK. Subtests passed 0/2. Unexpected 2
FAIL Removing the open attribute from an open modal dialog should run the closing algorithm. - assert_false: The dialog should not match :modal after closing. expected false got true
    at Test.<anonymous> (http://web-platform.test:8000/html/semantics/interactive-elements/the-dialog-element/dialog-close-via-attribute.html:28:3)
FAIL Removing the open attribute from an open non-modal dialog should fire a close event. - assert_true: The close event should be fired when removing the open attribute. expected true got false
    at Test.<anonymous> (http://web-platform.test:8000/html/semantics/interactive-elements/the-dialog-element/dialog-close-via-attribute.html:56:3)

 0:39.87 TEST_START: /html/semantics/interactive-elements/the-dialog-element/dialog-showModal.html
 0:40.07 TEST_END: Test OK. Subtests passed 9/10. Unexpected 1
FAIL when opening multiple dialogs, the most recently opened is rendered on top - assert_equals: expected Element node <dialog id="d10" open=""></dialog> but got Element node <dialog id="d11" open=""></dialog>
    at Test.<anonymous> (http://web-platform.test:8000/html/semantics/interactive-elements/the-dialog-element/dialog-showModal.html:168:5)
    at Test.step (http://web-platform.test:8000/resources/testharness.js:2622:25)
    at test (http://web-platform.test:8000/resources/testharness.js:633:30)
    at http://web-platform.test:8000/html/semantics/interactive-elements/the-dialog-element/dialog-showModal.html:138:3

 0:40.07 INFO No more tests
 0:40.07 INFO No more tests
 0:40.08 pid:2171 [2183:2234:0209/185743.020862:FATAL:bus.cc(1246)] D-Bus connection was disconnected. Aborting.
 0:40.08 pid:2171 [2183:2183:0209/185743.021325:ERROR:zygote_communication_linux.cc(290)] Failed to send GetTerminationStatus message to zygote
 0:40.08 pid:2171 [2183:2183:0209/185743.021341:WARNING:zygote_communication_linux.cc(302)] Socket closed prematurely.
 0:40.08 pid:2171 [2183:2183:0209/185743.021629:ERROR:zygote_communication_linux.cc(290)] Failed to send GetTerminationStatus message to zygote
 0:40.08 pid:2171 [2183:2183:0209/185743.021640:WARNING:zygote_communication_linux.cc(302)] Socket closed prematurely.
 0:40.08 pid:2171 [2183:2197:0209/185743.025943:FATAL:bus.cc(1246)] D-Bus connection was disconnected. Aborting.
 0:40.09 pid:2171 [0209/185743.037902:ERROR:file_io_posix.cc(145)] open /sys/devices/system/cpu/cpu0/cpufreq/scaling_cur_freq: No such file or directory (2)
 0:40.09 pid:2171 [0209/185743.037976:ERROR:file_io_posix.cc(145)] open /sys/devices/system/cpu/cpu0/cpufreq/scaling_max_freq: No such file or directory (2)
 0:40.08 INFO Closing logging queue
 0:40.08 INFO queue closed
 0:40.17 SUITE_END

web-platform-test
~~~~~~~~~~~~~~~~~
Ran 14 checks (12 subtests, 2 tests)
Expected results: 11
Unexpected results: 3
  subtest: 3 (3 fail)

Unexpected Results
------------------
/html/semantics/interactive-elements/the-dialog-element/dialog-close-via-attribute.html
  FAIL Removing the open attribute from an open modal dialog should run the closing algorithm. - assert_false: The dialog should not match :modal after closing. expected false got true
    at Test.<anonymous> (http://web-platform.test:8000/html/semantics/interactive-elements/the-dialog-element/dialog-close-via-attribute.html:28:3)
  FAIL Removing the open attribute from an open non-modal dialog should fire a close event. - assert_true: The close event should be fired when removing the open attribute. expected true got false
    at Test.<anonymous> (http://web-platform.test:8000/html/semantics/interactive-elements/the-dialog-element/dialog-close-via-attribute.html:56:3)
/html/semantics/interactive-elements/the-dialog-element/dialog-showModal.html
  FAIL when opening multiple dialogs, the most recently opened is rendered on top - assert_equals: expected Element node <dialog id="d10" open=""></dialog> but got Element node <dialog id="d11" open=""></dialog>
    at Test.<anonymous> (http://web-platform.test:8000/html/semantics/interactive-elements/the-dialog-element/dialog-showModal.html:168:5)
    at Test.step (http://web-platform.test:8000/resources/testharness.js:2622:25)
    at test (http://web-platform.test:8000/resources/testharness.js:633:30)
    at http://web-platform.test:8000/html/semantics/interactive-elements/the-dialog-element/dialog-showModal.html:138:3
 0:40.17 INFO Got 2 unexpected results, with 0 unexpected passes
 0:40.17 wptserve INFO Stopped WebTransport over HTTP/3 server on 127.0.0.1:11000
 0:40.22 wptserve INFO Stopped http server on 127.0.0.1:8000
 0:40.26 wptserve INFO Stopped http server on 127.0.0.1:8446
 0:40.28 wptserve INFO Stopped http server on 127.0.0.1:8443
 0:40.28 wptserve INFO Stopped http server on 127.0.0.1:9000
 0:40.28 wptserve INFO Close on: (<AddressFamily.AF_INET: 2>, <SocketKind.SOCK_STREAM: 1>, 6, '', ('127.0.0.1', 8888))
 0:40.28 wptserve INFO Stopped http server on 127.0.0.1:8001
 0:40.28 wptserve INFO Close on: (<AddressFamily.AF_INET: 2>, <SocketKind.SOCK_STREAM: 1>, 6, '', ('127.0.0.1', 8889))
 0:40.28 wptserve INFO Stopped http server on 127.0.0.1:8445
 0:40.28 wptserve INFO Stopped http server on 127.0.0.1:8444
 0:40.28 wptserve INFO Stopped http server on 127.0.0.1:8002
 0:40.28 wptserve INFO Stopped http server on 127.0.0.1:8003
 0:40.47 INFO Removed font: Ahem.ttf
 0:40.49 INFO Closing logging queue
 0:40.49 INFO queue closed
 0:40.50 INFO Tolerating 2 unexpected results
[taskcluster 2024-02-09 18:57:44.777Z] === Task Finished ===
[taskcluster 2024-02-09 18:57:45.819Z] Successful task run with exit code: 0 completed in 144.916 seconds
View more details on Community-TC Integration