[css-flex] Change expectations of two aspect-ratio tests #36113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Sep 27, 2022
New expectations incorporate an item's min-intrinsic size as part of flex's automatic minimum sizing. The new expectations are arguably what the spec currently calls for AND what the spec authors originally intended AND are consistent with both relevant proposals in w3c/csswg-drafts#6794 Also discussed at web-platform-tests/interop#139 (comment) Change-Id: I3c6ecdf66fbb4ee745c88b6b2a4dbecfb9913908 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3924134 Commit-Queue: David Grogan <[email protected]> Reviewed-by: Ian Kilpatrick <[email protected]> Cr-Commit-Position: refs/heads/main@{#1052123}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3924134
branch
from
21bce89 to
2e78219
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New expectations incorporate an item's min-intrinsic size as part of
flex's automatic minimum sizing.
The new expectations are arguably what the spec currently calls for AND
what the spec authors originally intended AND are consistent with both
relevant proposals in w3c/csswg-drafts#6794
Also discussed at
web-platform-tests/interop#139 (comment)
Change-Id: I3c6ecdf66fbb4ee745c88b6b2a4dbecfb9913908
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3924134
Commit-Queue: David Grogan <[email protected]>
Reviewed-by: Ian Kilpatrick <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1052123}