Rename :popup-open pseudo class to :top-layer #34238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
May 27, 2022
This CL just does a rename for the :top-layer pseudo class. It does not change behavior, which is/was that this pseudo class only applies to elements using the Popup API [1], and not to all elements that might inhabit the top layer. That will need to wait for a CSSWG resolution. But for now, the [2] resolution means we should use this pseudo class for the Popup API prototype starting now. [1] https://open-ui.org/components/popup.research.explainer [2] openui/open-ui#470 (comment) Bug: 1307772 Change-Id: I81a89132b84346a360d7b580f5f39be9da697bdc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3668918 Commit-Queue: Dan Clark <[email protected]> Auto-Submit: Mason Freed <[email protected]> Reviewed-by: Dan Clark <[email protected]> Cr-Commit-Position: refs/heads/main@{#1008430}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3668918
branch
from
f9ae377 to
09c0458
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CL just does a rename for the :top-layer pseudo class. It does
not change behavior, which is/was that this pseudo class only applies
to elements using the Popup API [1], and not to all elements that
might inhabit the top layer. That will need to wait for a CSSWG
resolution. But for now, the [2] resolution means we should use this
pseudo class for the Popup API prototype starting now.
[1] https://open-ui.org/components/popup.research.explainer
[2] openui/open-ui#470 (comment)
Bug: 1307772
Change-Id: I81a89132b84346a360d7b580f5f39be9da697bdc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3668918
Commit-Queue: Dan Clark <[email protected]>
Auto-Submit: Mason Freed <[email protected]>
Reviewed-by: Dan Clark <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1008430}