Only reflect valid popup values #34021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
May 10, 2022
This was resolved in [1] - only valid values for the `popup` attribute should be reflected, so that feature detection can be used on the values. [1] openui/open-ui#491 (comment) Bug: 1307772 Change-Id: I932a28bd48e336cf01253a971804dc00dcd099fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3639122 Auto-Submit: Mason Freed <[email protected]> Reviewed-by: Joey Arhar <[email protected]> Commit-Queue: Joey Arhar <[email protected]> Cr-Commit-Position: refs/heads/main@{#1001641}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3639122
branch
from
8392967 to
ed511da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was resolved in [1] - only valid values for the
popupattributeshould be reflected, so that feature detection can be used on the values.
[1] openui/open-ui#491 (comment)
Bug: 1307772
Change-Id: I932a28bd48e336cf01253a971804dc00dcd099fa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3639122
Auto-Submit: Mason Freed <[email protected]>
Reviewed-by: Joey Arhar <[email protected]>
Commit-Queue: Joey Arhar <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1001641}