Avoid calling CompositorPropertyAnimationsHaveNoEffect when effect->I…

…sCurrent() is false. Being stricter about compositing only the relevant property tree nodes for relevant animations (https://crrev.com/c/3307117) has made the DCHECK()s in CompositorPropertyAnimationsHaveNoEffect more sensitive. In particular, those DCHECK()s, which ensure that either no properties of an animation or all properties of an animation are composited, will sometimes (prior to this change) run for animations that are not current. This is a case where other animations might have caused some (but not all) of the properties to be composited, yet this animation (in UpdateAnimationFlagsForAnimation in css_animations.cc) will not set the flags for this animation that cause the properties it animates to be composited. Avoiding calling CompositorPropertyAnimationsHaveNoEffect in such cases avoids this problem. Fixed: 1319304 Change-Id: If3db29b98ce319c57e27acbe2f47d7319ec8230b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3609191 Commit-Queue: David Baron <[email protected]> Reviewed-by: Robert Flack <[email protected]> Cr-Commit-Position: refs/heads/main@{#997837}
web-platform-tests · Apr 29, 2022 · dd1250a · dd1250a
1 parent 4c555eb
commit dd1250a
Showing 1 changed file with 17 additions and 0 deletions.
diff --git a/web-animations/crashtests/partially-overlapping-animations-one-not-current-001.html b/web-animations/crashtests/partially-overlapping-animations-one-not-current-001.html
@@ -0,0 +1,17 @@
+<!DOCTYPE html>
+<html>
+<title>CSS Test (Animations): Reparenting an element with a web animation on the compositor</title>
+<link rel="author" title="L. David Baron" href="https://dbaron.org/">
+<link rel="author" title="Google" href="http://www.google.com/">
+<link rel="help" href="https://bugs.chromium.org/p/chromium/issues/detail?id=1319304">
+<meta name="assert" content="This should not crash.">
+
+<script>
+window.onload = function(){
+  let div = document.querySelector("div");
+  let a1 = div.animate([{"transform": "translateX(10px)", "opacity": "0.4"}], { duration: 1000 });
+  a1.reverse();
+  let a2 = div.animate([{"transform": "translateY(10px)"}], { duration: 1000 });
+}
+</script>
+<div>X</div>