Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add anchor-size rules to anchor-positioning #2483

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add anchor-size rules to anchor-positioning #2483

wants to merge 2 commits into from

Conversation

jamesnw
Copy link
Collaborator

@jamesnw jamesnw commented Dec 20, 2024

No description provided.

@github-actions github-actions bot added the feature definition Creating or defining new features or groups of features. label Dec 20, 2024
captainbrosset
captainbrosset approved these changes Jan 7, 2025
View reviewed changes
Copy link
Contributor

@captainbrosset captainbrosset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a later addition? Either way, it makes sense for me to bundle it in this feature because:

  • Anchor positioning is still very early in the making and not baseline.
  • anchor-size is part of the same spec as the rest of the anchor positioning stuff.

@jamesnw
Copy link
Collaborator Author

jamesnw commented Jan 7, 2025

Is this a later addition?

Initially, the spec only supported anchor-size() on sizing properties, but it was updated to allow anchor-size() on insets and margins as well, so the new keys refer to that.

I agree it makes sense to keep this bundled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@captainbrosset captainbrosset captainbrosset approved these changes

Assignees
No one assigned
Labels
feature definition Creating or defining new features or groups of features.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jamesnw @captainbrosset