Add private click measurement #2467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
feature definition
ddbeck
approved these changes
Jan 7, 2025
There was a problem hiding this comment.
This is ready to go, if you like my description suggestion. Otherwise we can go another round here.
(I'm not sure how much you'll be on this in this calendar year. We have a chat schedule later today, so I figure I'll figure out how to move this forward then.)
Co-authored-by: Daniel D. Beck <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Welp, this seems both integrated and different from attribution reporting. Competing approaches maybe? Need to do some research here.
Ok looks like these might be competing approaches, would need to be separate features at this point.
2022 seems like so long ago. I'd forgotten about PCM.