-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add global element attributes/properties #2423
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leaving some early comments on contenteditable.
Co-authored-by: Patrick Brosset <[email protected]>
… into global-attrs
As they always say: "the last 20% of keys become 80% of the features" 😅
|
Co-authored-by: Patrick Brosset <[email protected]>
Co-authored-by: Patrick Brosset <[email protected]>
Co-authored-by: Patrick Brosset <[email protected]>
Co-authored-by: Patrick Brosset <[email protected]>
Co-authored-by: Patrick Brosset <[email protected]>
Co-authored-by: Patrick Brosset <[email protected]>
Co-authored-by: Patrick Brosset <[email protected]>
Co-authored-by: Patrick Brosset <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Partial review (up to but not including the contenteditables). I'll revisit this later, but there's some stuff to chew on already. Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, my completed review.
Co-authored-by: Daniel D. Beck <[email protected]>
Co-authored-by: Daniel D. Beck <[email protected]>
Co-authored-by: Daniel D. Beck <[email protected]>
Co-authored-by: Daniel D. Beck <[email protected]>
Co-authored-by: Daniel D. Beck <[email protected]>
Co-authored-by: Daniel D. Beck <[email protected]>
Co-authored-by: Daniel D. Beck <[email protected]>
Co-authored-by: Daniel D. Beck <[email protected]>
Co-authored-by: Daniel D. Beck <[email protected]>
Co-authored-by: Daniel D. Beck <[email protected]>
Co-authored-by: Daniel D. Beck <[email protected]>
Co-authored-by: Daniel D. Beck <[email protected]>
Co-authored-by: Daniel D. Beck <[email protected]>
Co-authored-by: Daniel D. Beck <[email protected]>
Co-authored-by: Daniel D. Beck <[email protected]>
Co-authored-by: Daniel D. Beck <[email protected]>
Co-authored-by: Daniel D. Beck <[email protected]>
… into global-attrs
working through the non-obvious ones...
-> new feature
-> could group?
TBD
-> new feature
-> new feature
TBD
-> new feature
-> new feature