Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add global element attributes/properties #2423

Merged
merged 48 commits into from
Dec 18, 2024

Conversation

autonome
Copy link
Collaborator

@autonome autonome commented Dec 10, 2024

working through the non-obvious ones...

  • api.HTMLElement.accessKey
  • api.HTMLElement.accessKeyLabel

-> new feature

  • api.HTMLElement.autocapitalize
  • api.HTMLElement.autocorrect
  • api.HTMLElement.spellcheck

-> could group?

  • api.HTMLElement.blur
  • api.HTMLElement.change_event
  • api.HTMLElement.click
  • api.HTMLElement.command_event

TBD

  • api.HTMLElement.contentEditable
  • api.HTMLElement.contentEditable.plaintext-only
  • api.HTMLElement.inputMode
  • api.HTMLElement.isContentEditable

-> new feature

  • api.HTMLElement.enterKeyHint

-> new feature

  • api.HTMLElement.focus
  • api.HTMLElement.focus.options_focusVisible_parameter
  • api.HTMLElement.focus.options_preventScroll_parameter

TBD

  • api.HTMLElement.lang

-> new feature

  • api.HTMLElement.title

-> new feature

@github-actions github-actions bot added the feature definition Creating or defining new features or groups of features. label Dec 10, 2024
Copy link
Contributor

@captainbrosset captainbrosset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leaving some early comments on contenteditable.

features/contenteditable.yml Outdated Show resolved Hide resolved
features/contenteditable.yml Outdated Show resolved Hide resolved
@autonome autonome changed the title Add global attributes Add global element attributes/properties Dec 13, 2024
@autonome
Copy link
Collaborator Author

autonome commented Dec 13, 2024

As they always say: "the last 20% of keys become 80% of the features" 😅

@autonome autonome marked this pull request as ready for review December 13, 2024 14:22
features/enterkeyhint.yml Outdated Show resolved Hide resolved
features/focus-apis.yml Outdated Show resolved Hide resolved
features/lang-attr.yml Outdated Show resolved Hide resolved
features/accesskey.yml Outdated Show resolved Hide resolved
features/autocapitalize.yml Outdated Show resolved Hide resolved
features/autocorrect.yml Outdated Show resolved Hide resolved
features/focus-apis.yml Outdated Show resolved Hide resolved
features/spellcheck.yml Outdated Show resolved Hide resolved
features/title-attr.yml Outdated Show resolved Hide resolved
autonome and others added 8 commits December 17, 2024 21:14
Co-authored-by: Patrick Brosset <[email protected]>
Co-authored-by: Patrick Brosset <[email protected]>
Co-authored-by: Patrick Brosset <[email protected]>
Co-authored-by: Patrick Brosset <[email protected]>
Co-authored-by: Patrick Brosset <[email protected]>
Co-authored-by: Patrick Brosset <[email protected]>
Co-authored-by: Patrick Brosset <[email protected]>
Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Partial review (up to but not including the contenteditables). I'll revisit this later, but there's some stuff to chew on already. Thank you!

features/accesskey.yml Outdated Show resolved Hide resolved
features/accesskey.yml Outdated Show resolved Hide resolved
features/autocapitalize.yml Outdated Show resolved Hide resolved
features/autocorrect.yml Outdated Show resolved Hide resolved
features/change-event.yml Outdated Show resolved Hide resolved
features/click.yml Outdated Show resolved Hide resolved
features/command-event.yml Outdated Show resolved Hide resolved
Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, my completed review.

features/contenteditable.yml Outdated Show resolved Hide resolved
features/contenteditable.yml Show resolved Hide resolved
features/contenteditable-plaintextonly.yml Show resolved Hide resolved
features/contenteditable-plaintextonly.yml Outdated Show resolved Hide resolved
features/contenteditable-plaintextonly.yml Outdated Show resolved Hide resolved
features/lang-attr.yml Outdated Show resolved Hide resolved
features/popover.yml Outdated Show resolved Hide resolved
features/spellcheck.yml Outdated Show resolved Hide resolved
features/title-attr.yml Outdated Show resolved Hide resolved
features/title-attr.yml Outdated Show resolved Hide resolved
autonome and others added 22 commits December 18, 2024 18:21
Co-authored-by: Daniel D. Beck <[email protected]>
Co-authored-by: Daniel D. Beck <[email protected]>
Co-authored-by: Daniel D. Beck <[email protected]>
Co-authored-by: Daniel D. Beck <[email protected]>
Co-authored-by: Daniel D. Beck <[email protected]>
Co-authored-by: Daniel D. Beck <[email protected]>
Co-authored-by: Daniel D. Beck <[email protected]>
Co-authored-by: Daniel D. Beck <[email protected]>
Co-authored-by: Daniel D. Beck <[email protected]>
@autonome autonome requested a review from ddbeck December 18, 2024 12:05
@ddbeck ddbeck dismissed captainbrosset’s stale review December 18, 2024 15:27

Suggestions applied

@ddbeck ddbeck merged commit 1862105 into web-platform-dx:main Dec 18, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature definition Creating or defining new features or groups of features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants