Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more HTML spec keys #2405

Merged
merged 22 commits into from
Dec 20, 2024
Merged

Add more HTML spec keys #2405

merged 22 commits into from
Dec 20, 2024

Conversation

autonome
Copy link
Collaborator

@autonome autonome commented Dec 6, 2024

No description provided.

@github-actions github-actions bot added the feature definition Creating or defining new features or groups of features. label Dec 6, 2024
@autonome
Copy link
Collaborator Author

autonome commented Dec 9, 2024

Ok nothing too crazy in here, getting through the sprinkly bits.

@autonome autonome marked this pull request as ready for review December 9, 2024 13:34
captainbrosset
captainbrosset requested changes Dec 11, 2024
View reviewed changes
features/dom.yml Outdated Show resolved Hide resolved
features/offscreen-canvas.yml Show resolved Hide resolved
@autonome autonome requested a review from ddbeck December 16, 2024 13:09
@ddbeck ddbeck mentioned this pull request Dec 19, 2024
Merged
ddbeck
ddbeck requested changes Dec 19, 2024
View reviewed changes
Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small changes in line comments.

features/dom.yml Outdated Show resolved Hide resolved
features/dom.yml Show resolved Hide resolved
features/gethtml.yml Outdated Show resolved Hide resolved
@autonome autonome requested a review from ddbeck December 19, 2024 17:13
captainbrosset
captainbrosset requested changes Dec 20, 2024
View reviewed changes
Copy link
Contributor

@captainbrosset captainbrosset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found one key that might need to be moved to another feature. But otherwise looks great.

features/dom.yml Outdated Show resolved Hide resolved
@ddbeck ddbeck merged commit 9d1b04d into web-platform-dx:main Dec 20, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesnw jamesnw jamesnw left review comments

@captainbrosset captainbrosset captainbrosset approved these changes

@ddbeck ddbeck ddbeck approved these changes

Assignees
No one assigned
Labels
feature definition Creating or defining new features or groups of features.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@autonome @ddbeck @jamesnw @captainbrosset