Add features and keys from CSSOM View Module spec #2363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
feature definition
autonome
changed the title
jamesnw
approved these changes
Dec 3, 2024
Co-authored-by: James Stuckey Weber <[email protected]>
Co-authored-by: James Stuckey Weber <[email protected]>
Co-authored-by: James Stuckey Weber <[email protected]>
Co-authored-by: James Stuckey Weber <[email protected]>
|
Lots of stuff in here, so getting a 3rd pair of eyes. |
ddbeck
reviewed
Dec 10, 2024
captainbrosset
approved these changes
Dec 10, 2024
Co-authored-by: Daniel D. Beck <[email protected]>
Co-authored-by: Daniel D. Beck <[email protected]>
Co-authored-by: Daniel D. Beck <[email protected]>
Co-authored-by: Patrick Brosset <[email protected]>
ddbeck
approved these changes
Dec 19, 2024
Co-authored-by: Daniel D. Beck <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Epic bucket of stuff. This PR parcels out almost everything in the CSSOM View spec across a number of features.
While it looks big, there's ultimately not a lot of controversial stuff in here. Many of the keys seemed to have a straightforward home already in existing features.
New features split out so far are Caniuse features:
New features split out, but not based on Caniuse features:
The only keys remaining from that spec now are:
getBoxQuadskeys, which are behind a flag on Firefox since ~2014Something that feels ok but not ideal is putting all the size/positional bits of
ElementandWindowintoDOMandWindowfeatures, respectively. They are certainly properties of those, and it didn't move any baselines, but they are a different set of use-cases. But this option is likely better than a new feature for this, as I didn't find any great evidence showing developer POV around CSSOM View as a whole thing on its own.