Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:amd-define-in-parameter (#9078) #9083

Closed

Conversation

ununian
Copy link

@ununian ununian commented Jan 22, 2025

Summary

to fix: #9078

I couldn't find a way to get the parent of Expr. I can only add a parameter to describe if the ident is a function's formal parameter. I'm not sure if this is appropriate.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@CLAassistant
Copy link

CLAassistant commented Jan 22, 2025

CLA assistant check
All committers have signed the CLA.

Copy link

netlify bot commented Jan 22, 2025

Deploy Preview for rspack canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit 7858a8e
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/6790add06d67d000084ab426

@chenjiahan chenjiahan requested a review from ahabhgk January 22, 2025 09:00
Copy link

codspeed-hq bot commented Jan 22, 2025

CodSpeed Performance Report

Merging #9083 will not alter performance

Comparing ununian:fix/amd-define-in-parameter (7858a8e) with main (6642974)

🎉 Hooray! codspeed-node just leveled up to 4.0.0!

A heads-up, this is a breaking change and it might affect your current performance baseline a bit. But here's the exciting part - it's packed with new, cool features and promises improved result stability 🥳!
Curious about what's new? Visit our releases page to delve into all the awesome details about this new version.

Summary

✅ 3 untouched benchmarks

@ahabhgk
Copy link
Contributor

ahabhgk commented Jan 22, 2025

Sorry, wrong solution, prefer #9088, but still thank you

@ahabhgk ahabhgk closed this Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants