Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support custom parser for json type #8947

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

feat: support custom parser for json type #8947

wants to merge 4 commits into from
+157 −53

Conversation

cbbfcd
Copy link
Contributor

@cbbfcd cbbfcd commented Jan 7, 2025

Partial support for issue-8785.

Summary

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added the release: feature release: feature related release(mr only) label Jan 7, 2025
@netlify Netlify
Copy link

netlify bot commented Jan 7, 2025 •
edited
Loading

✅ Deploy Preview for rspack canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit 8151332
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/677fa177e6fb5c000861b21e

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jan 7, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #8947 will not alter performance

Comparing cbbfcd:feat/support-json-parser-parse (8151332) with main (3c73d06)

Summary

✅ 3 untouched benchmarks

ahabhgk
ahabhgk approved these changes Jan 9, 2025
View reviewed changes
Copy link
Contributor

@ahabhgk ahabhgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ahabhgk
Copy link
Contributor

ahabhgk commented Jan 9, 2025

Need rebase and update api change (run pnpm api-extractor:local)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LingyuCoder LingyuCoder LingyuCoder left review comments

@ahabhgk ahabhgk ahabhgk approved these changes

Assignees
No one assigned
Labels
release: feature release: feature related release(mr only)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cbbfcd @ahabhgk @LingyuCoder