Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support invalidate persistent cache using config.mode and config.name #8920

Merged
merged 2 commits into from
Jan 2, 2025

Conversation

jerrykingxyz
Copy link
Contributor

@jerrykingxyz jerrykingxyz commented Jan 2, 2025

Summary

Support invalidate persistent cache using config.mode and config.name.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added release: feature release: feature related release(mr only) team The issue/pr is created by the member of Rspack. labels Jan 2, 2025
Copy link

netlify bot commented Jan 2, 2025

Deploy Preview for rspack ready!

Name Link
🔨 Latest commit 52d566d
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/677648a8afe8d50008aabfcf
😎 Deploy Preview https://deploy-preview-8920--rspack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codspeed-hq bot commented Jan 2, 2025

CodSpeed Performance Report

Merging #8920 will not alter performance

Comparing jerry/cache (52d566d) with main (aa8732c)

Summary

✅ 3 untouched benchmarks

@jerrykingxyz jerrykingxyz merged commit 96084cc into main Jan 2, 2025
38 checks passed
@jerrykingxyz jerrykingxyz deleted the jerry/cache branch January 2, 2025 08:46
@h-a-n-a h-a-n-a mentioned this pull request Jan 7, 2025
@slorber
Copy link

slorber commented Jan 7, 2025

Hey 👋

Just wondering, do you also plan to support cache.name like webpack?

On Docusaurus we have to manage multiple caches with

const name = isServer ? 'server' : 'client';
const mode = isProd ? 'production' : 'development';


cache.name: `${name}-${mode}-${props.i18n.currentLocale}`

More details here:

@jerrykingxyz
Copy link
Contributor Author

jerrykingxyz commented Jan 9, 2025

@slorber We currently have no plans to support cache.name since this field provides the same features as cache.version, just use cache.version.

cache.version: props.i18n.currentLocale + ...

@chenjiahan
Copy link
Member

@jerrykingxyz We can add some guides for migrating from the webpack cache configuration to Rspack experiments cache.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: feature release: feature related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants