Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: path relative and join method #8903

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

SyMind
Copy link
Member

@SyMind SyMind commented Dec 31, 2024

Summary

  1. In JavaScript path.join('/a', '/b') == '/a/b', it is different behavior between Rust.
  2. Use sugar_path for calculate relative path.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added team The issue/pr is created by the member of Rspack. release: bug fix release: bug related release(mr only) labels Dec 31, 2024
Copy link

netlify bot commented Dec 31, 2024

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 9b64851
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/67738ff29e55540008e0f5e1

Copy link

codspeed-hq bot commented Dec 31, 2024

CodSpeed Performance Report

Merging #8903 will not alter performance

Comparing fix-relative-and-join (9b64851) with main (dea6d62)

🎉 Hooray! codspeed-rust just leveled up to 2.7.2!

A heads-up, this is a breaking change and it might affect your current performance baseline a bit. But here's the exciting part - it's packed with new, cool features and promises improved result stability 🥳!
Curious about what's new? Visit our releases page to delve into all the awesome details about this new version.

Summary

✅ 3 untouched benchmarks

@SyMind SyMind marked this pull request as ready for review December 31, 2024 04:10
@SyMind SyMind force-pushed the fix-relative-and-join branch 3 times, most recently from 00927c0 to 695530e Compare December 31, 2024 06:07
@SyMind SyMind force-pushed the fix-relative-and-join branch from 695530e to 9b64851 Compare December 31, 2024 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant