fix: copy filename_template ito split chunks #8900
Open
+49
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is a reimplementation of a PR I opened against webpack (webpack/webpack#19104). We found that the
splitChunks.cacheGroups.{cacheGroup}.filename
config option was not being respected for any split initial chunks created based on themaxSize
-based deterministic grouping.I added a stats test case which configures
vendors
cache group (withfilename
options) for anything innode_modules
but with a smallmaxSize
so it creates many little chunks. This is the diff for the test from before and after the fix in case it helps:Alternatives considered
It seems like we could move this logic in to the
split
method on theChunk
struct but I'm not sure if that is preferred.Checklist