Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: include versions in error message for version mismatch #8899

Merged

Conversation

haocheng6
Copy link
Contributor

Summary

This PR fixes the error message for unmatched versions to properly include version numbers.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added the release: bug fix release: bug related release(mr only) label Dec 30, 2024
Copy link

netlify bot commented Dec 30, 2024

Deploy Preview for rspack ready!

Name Link
🔨 Latest commit 3bd6be1
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/6777a2a21fda16000811befd
😎 Deploy Preview https://deploy-preview-8899--rspack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

chenjiahan
chenjiahan previously approved these changes Dec 31, 2024
Copy link
Member

@chenjiahan chenjiahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@chenjiahan chenjiahan enabled auto-merge (squash) December 31, 2024 07:29
Copy link

codspeed-hq bot commented Jan 3, 2025

CodSpeed Performance Report

Merging #8899 will not alter performance

Comparing haocheng6:fix-unmatched-version-error-message (3bd6be1) with main (3f5fc65)

Summary

✅ 3 untouched benchmarks

@chenjiahan chenjiahan merged commit c5d582e into web-infra-dev:main Jan 3, 2025
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: bug fix release: bug related release(mr only)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants