-
-
Notifications
You must be signed in to change notification settings - Fork 605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: introducing the faster code-splitting algorithm #8823
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for rspack canceled.Built without sensitive environment variables
|
CodSpeed Performance ReportMerging #8823 will not alter performanceComparing Summary
|
dab14a8
to
d4e7793
Compare
d4e7793
to
159fb7d
Compare
.styleB { | ||
background: blue; | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Webpack/Rspack legacy code-splitting bug, you can see entry modules from config is A then B
ac5893a
to
4526881
Compare
maybe we should add a benchmark case with lots of dynamic import module first and to see the bench metrics avoid future regression |
📝 Benchmark detail: Open
|
bca01bd
to
706ae15
Compare
4a23903
to
4ea7c45
Compare
4ea7c45
to
91c3ff2
Compare
25c0c61
to
391f835
Compare
391f835
to
d308f3e
Compare
d308f3e
to
425c331
Compare
Summary
Change the algorithm of code-splitting.
Making it more maintainable, concurrent and easy to working with incoming incremental arch.
Because of the multi-threads, now the code-splitting is more performant than before even using single thread. There can be a huge improvement on large repo.
There is a internal test project which contains about 1.5 million chunk modules, using many dynamic imports, costs about 1200 ms to complete a whole code-splitting phase, using the new algorithm on my 15 core MacBook Pro M1, only takse 600 ms to finish !
The detailed benchmark data will be present soon
Checklist