Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support module graph connection js api #8812

Merged
merged 9 commits into from
Dec 23, 2024

Conversation

SyMind
Copy link
Member

@SyMind SyMind commented Dec 23, 2024

Summary

Supports the JavaScript API for module graph connection.

This API is used in React server components to traverse the module graph. Moreover, it is faster than the dependency JavaScript API for this job.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added the release: feature release: feature related release(mr only) label Dec 23, 2024
Copy link

netlify bot commented Dec 23, 2024

Deploy Preview for rspack canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit 24a7138
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/676914b79cfe5500088271b8

Copy link

netlify bot commented Dec 23, 2024

Deploy Preview for rspack canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit ee93cb8
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/67693feb4f490a0008855984

Copy link

codspeed-hq bot commented Dec 23, 2024

CodSpeed Performance Report

Merging #8812 will not alter performance

Comparing SyMind:feat-connection (ee93cb8) with main (db6a793)

Summary

✅ 1 untouched benchmarks
🆕 2 new benchmarks
⁉️ 1 dropped benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main SyMind:feat-connection Change
⁉️ Traverse module graph by dependencies 1.5 ms N/A N/A
🆕 Traverse module graph by connections N/A 359.4 µs N/A
🆕 Traverse module graph by dependencies N/A 1.5 ms N/A

@SyMind SyMind force-pushed the feat-connection branch 2 times, most recently from b9b2373 to 6777f03 Compare December 23, 2024 10:07
@SyMind SyMind marked this pull request as ready for review December 23, 2024 10:11
@LingyuCoder LingyuCoder merged commit c698b83 into web-infra-dev:main Dec 23, 2024
30 of 31 checks passed
@SyMind SyMind deleted the feat-connection branch December 23, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: feature release: feature related release(mr only)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants