Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: duplicate move lock files #8732

Merged
merged 4 commits into from
Dec 17, 2024
Merged

fix: duplicate move lock files #8732

merged 4 commits into from
Dec 17, 2024

Conversation

LingyuCoder
Copy link
Contributor

@LingyuCoder LingyuCoder commented Dec 16, 2024

Summary

  1. should not generate move.lock for every scope
  2. add lock for removing
  3. add test case for multiple scopes

generate by copilot

This pull request refactors the scope management and file handling logic in the rspack_storage crate. The changes aim to simplify the code, improve efficiency, and ensure better error handling. The key changes include modifying the scope writing strategy, adding new utility functions, and updating test cases accordingly.

Scope Management and File Handling Improvements:

New Utility Functions:

Test Case Updates:

Miscellaneous Changes:

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack. labels Dec 16, 2024
Copy link

netlify bot commented Dec 16, 2024

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit b0177cc
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/67601df686c97b0008f3edcf

Copy link

netlify bot commented Dec 16, 2024

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 79f5427
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/6760ece878fb6c0008fba8ee

@LingyuCoder LingyuCoder changed the title fix: rduplicate move lock files fix: duplicate move lock files Dec 16, 2024
@LingyuCoder LingyuCoder enabled auto-merge (squash) December 17, 2024 03:24
@LingyuCoder LingyuCoder merged commit da44eab into main Dec 17, 2024
31 checks passed
@LingyuCoder LingyuCoder deleted the fix/duplicate-move-lock branch December 17, 2024 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants