Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: faster substring of rspack-sources #8731

Merged
merged 3 commits into from
Dec 17, 2024
Merged

perf: faster substring of rspack-sources #8731

merged 3 commits into from
Dec 17, 2024

Conversation

h-a-n-a
Copy link
Contributor

@h-a-n-a h-a-n-a commented Dec 16, 2024

Summary

Syncing with web-infra-dev/rspack-sources#149

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@h-a-n-a
Copy link
Contributor Author

h-a-n-a commented Dec 16, 2024

!bench

@github-actions github-actions bot added team The issue/pr is created by the member of Rspack. release: performance release: performance related release(mr only) labels Dec 16, 2024
Copy link

netlify bot commented Dec 16, 2024

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 929c689
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/676112f2e54afc00083ad9a4

@rspack-bot
Copy link

rspack-bot commented Dec 16, 2024

📝 Benchmark detail: Open

Name Base (2024-12-16 2f4992b) Current Change
10000_big_production-mode_disable-minimize + exec 38.4 s ± 586 ms 38 s ± 616 ms -1.08 %
10000_development-mode + exec 1.89 s ± 64 ms 1.85 s ± 77 ms -2.06 %
10000_development-mode_hmr + exec 690 ms ± 23 ms 686 ms ± 32 ms -0.52 %
10000_production-mode + exec 2.49 s ± 47 ms 2.47 s ± 59 ms -1.01 %
arco-pro_development-mode + exec 1.77 s ± 76 ms 1.78 s ± 63 ms +0.30 %
arco-pro_development-mode_hmr + exec 379 ms ± 1.4 ms 379 ms ± 2 ms -0.02 %
arco-pro_production-mode + exec 3.33 s ± 128 ms 3.27 s ± 93 ms -1.86 %
arco-pro_production-mode_generate-package-json-webpack-plugin + exec 3.41 s ± 149 ms 3.3 s ± 89 ms -3.35 %
arco-pro_production-mode_traverse-chunk-modules + exec 3.34 s ± 90 ms 3.27 s ± 45 ms -2.17 %
threejs_development-mode_10x + exec 1.62 s ± 14 ms 1.61 s ± 22 ms -0.36 %
threejs_development-mode_10x_hmr + exec 787 ms ± 10 ms 792 ms ± 35 ms +0.65 %
threejs_production-mode_10x + exec 5.42 s ± 77 ms 5.25 s ± 43 ms -3.07 %
10000_big_production-mode_disable-minimize + rss memory 9499 MiB ± 255 MiB 9437 MiB ± 29.8 MiB -0.66 %
10000_development-mode + rss memory 629 MiB ± 18.3 MiB 682 MiB ± 23.3 MiB +8.46 %
10000_development-mode_hmr + rss memory 1515 MiB ± 164 MiB 1529 MiB ± 419 MiB +0.96 %
10000_production-mode + rss memory 590 MiB ± 18 MiB 664 MiB ± 42.2 MiB +12.45 %
arco-pro_development-mode + rss memory 570 MiB ± 26.4 MiB 592 MiB ± 37.5 MiB +3.91 %
arco-pro_development-mode_hmr + rss memory 640 MiB ± 39 MiB 645 MiB ± 56.9 MiB +0.86 %
arco-pro_production-mode + rss memory 690 MiB ± 48.5 MiB 738 MiB ± 57.5 MiB +6.90 %
arco-pro_production-mode_generate-package-json-webpack-plugin + rss memory 736 MiB ± 73.2 MiB 745 MiB ± 57.5 MiB +1.25 %
arco-pro_production-mode_traverse-chunk-modules + rss memory 728 MiB ± 34.9 MiB 754 MiB ± 59.9 MiB +3.62 %
threejs_development-mode_10x + rss memory 590 MiB ± 19.2 MiB 644 MiB ± 22.1 MiB +9.04 %
threejs_development-mode_10x_hmr + rss memory 1125 MiB ± 168 MiB 1114 MiB ± 181 MiB -1.02 %
threejs_production-mode_10x + rss memory 896 MiB ± 52.9 MiB 911 MiB ± 48.7 MiB +1.67 %

@h-a-n-a h-a-n-a changed the title perf: init perf: faster substring of rspack-sources Dec 17, 2024
@h-a-n-a h-a-n-a marked this pull request as ready for review December 17, 2024 05:22
@h-a-n-a h-a-n-a enabled auto-merge (squash) December 17, 2024 05:22
@h-a-n-a
Copy link
Contributor Author

h-a-n-a commented Dec 17, 2024

Hash change due to web-infra-dev/rspack-sources#142

@h-a-n-a h-a-n-a merged commit 9ba26cd into main Dec 17, 2024
32 checks passed
@h-a-n-a h-a-n-a deleted the perf-more-source branch December 17, 2024 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: performance release: performance related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants