Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: add AMD dependencies #7612

Closed
wants to merge 4 commits into from

Conversation

nilptr
Copy link
Contributor

@nilptr nilptr commented Aug 19, 2024

Summary

add AMD dependencies for #4313.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Aug 19, 2024

Deploy Preview for rspack ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 57377e1
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/66f0cd799ed4e000084693d7
😎 Deploy Preview https://deploy-preview-7612--rspack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nilptr nilptr force-pushed the nilptr/feat/amd-option branch from d1d0be1 to 151d5e2 Compare September 3, 2024 16:08
@hardfist
Copy link
Contributor

@nilptr you need review advice, please ping us

@nilptr nilptr force-pushed the nilptr/feat/amd-option branch from 151d5e2 to 57377e1 Compare September 23, 2024 02:07
@SoonIter
Copy link
Member

SoonIter commented Oct 8, 2024

Hello, is this still in progress?

@GiveMe-A-Name
Copy link
Member

GiveMe-A-Name commented Nov 1, 2024

@nilptr Do you need help ? This PR has not made progress in a long time.

@nilptr
Copy link
Contributor Author

nilptr commented Nov 10, 2024

hihi @GiveMe-A-Name sorry for late reply. I was busy with my job, didn't check github. Actually, I started a new branch, and this branch is discard. Let me close this PR and create a new one for review.

Currently, I have finished the AMDDefineDependencyParserPlugin and AMDRequireDependenciesBlockParserPlugin, and added test cases for them. So far they seem to work well. But I still need more time (maybe 1or2 weeks) to do some integration. I will discuss the details with you guys this week. cc: @ahabhgk

Thank you.

@nilptr nilptr closed this Nov 10, 2024
@nilptr nilptr deleted the nilptr/feat/amd-option branch December 7, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants