-
-
Notifications
You must be signed in to change notification settings - Fork 595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: warn case sensitive plugin #7606
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
!bench |
github-actions
bot
added
release: performance
release: performance related release(mr only)
team
The issue/pr is created by the member of Rspack.
labels
Aug 19, 2024
⏳ Triggered benchmark: Open |
✅ Deploy Preview for rspack canceled.
|
!bench |
📝 Benchmark detail: Open
|
JSerFeng
approved these changes
Aug 19, 2024
hardfist
reviewed
Aug 19, 2024
rspack_error = { version = "0.1.0", path = "../rspack_error" } | ||
rspack_hook = { version = "0.1.0", path = "../rspack_hook" } | ||
tracing = { workspace = true } | ||
rspack_collections = { path = "../rspack_collections" } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this need version field, otherwise it can't be published
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
release: performance
release: performance related release(mr only)
team
The issue/pr is created by the member of Rspack.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
For 9000 case (without case sensitive path, which is the common case in development), 8ms -> 4ms
And now this plugin will increase 1ms per 2000 modules, which is acceptable for now, we can consider to move it as production only plugin by default when it becomes the bottleneck
Checklist