Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: warn case sensitive plugin #7606

Merged
merged 1 commit into from
Aug 19, 2024
Merged

perf: warn case sensitive plugin #7606

merged 1 commit into from
Aug 19, 2024

Conversation

ahabhgk
Copy link
Contributor

@ahabhgk ahabhgk commented Aug 19, 2024

Summary

For 9000 case (without case sensitive path, which is the common case in development), 8ms -> 4ms

And now this plugin will increase 1ms per 2000 modules, which is acceptable for now, we can consider to move it as production only plugin by default when it becomes the bottleneck

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@ahabhgk
Copy link
Contributor Author

ahabhgk commented Aug 19, 2024

!bench

@github-actions github-actions bot added release: performance release: performance related release(mr only) team The issue/pr is created by the member of Rspack. labels Aug 19, 2024
@rspack-bot
Copy link

⏳ Triggered benchmark: Open

Copy link

netlify bot commented Aug 19, 2024

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit e296b21
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/66c2e20031c11b0008ea482c

@ahabhgk
Copy link
Contributor Author

ahabhgk commented Aug 19, 2024

!bench

@rspack-bot
Copy link

rspack-bot commented Aug 19, 2024

📝 Benchmark detail: Open

Name Base (2024-08-16 218bda0) Current Change
10000_development-mode + exec 2.35 s ± 21 ms 2.35 s ± 28 ms -0.20 %
10000_development-mode_hmr + exec 713 ms ± 13 ms 702 ms ± 11 ms -1.57 %
10000_production-mode + exec 3.02 s ± 38 ms 3.05 s ± 36 ms +1.12 %
arco-pro_development-mode + exec 1.91 s ± 68 ms 1.89 s ± 58 ms -1.31 %
arco-pro_development-mode_hmr + exec 439 ms ± 2 ms 437 ms ± 1.8 ms -0.59 %
arco-pro_production-mode + exec 3.48 s ± 110 ms 3.5 s ± 94 ms +0.80 %
arco-pro_production-mode_generate-package-json-webpack-plugin + exec 3.52 s ± 98 ms 3.54 s ± 98 ms +0.54 %
threejs_development-mode_10x + exec 1.71 s ± 14 ms 1.72 s ± 22 ms +0.53 %
threejs_development-mode_10x_hmr + exec 823 ms ± 9.3 ms 818 ms ± 9.2 ms -0.57 %
threejs_production-mode_10x + exec 5.53 s ± 39 ms 5.56 s ± 38 ms +0.44 %

@ahabhgk ahabhgk enabled auto-merge (squash) August 19, 2024 07:27
@ahabhgk ahabhgk requested review from SyMind and JSerFeng August 19, 2024 07:28
@ahabhgk ahabhgk merged commit debd406 into main Aug 19, 2024
35 checks passed
@ahabhgk ahabhgk deleted the perf-warn-case branch August 19, 2024 07:30
rspack_error = { version = "0.1.0", path = "../rspack_error" }
rspack_hook = { version = "0.1.0", path = "../rspack_hook" }
tracing = { workspace = true }
rspack_collections = { path = "../rspack_collections" }
Copy link
Contributor

@hardfist hardfist Aug 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this need version field, otherwise it can't be published

@chenjiahan chenjiahan mentioned this pull request Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: performance release: performance related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants