Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add more clippy rule #7594

Merged
merged 3 commits into from
Aug 21, 2024
Merged

refactor: add more clippy rule #7594

merged 3 commits into from
Aug 21, 2024

Conversation

hardfist
Copy link
Contributor

Summary

related to #7589

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@hardfist hardfist requested a review from jerrykingxyz as a code owner August 16, 2024 05:59
@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Aug 16, 2024
Copy link

netlify bot commented Aug 16, 2024

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 7b2291f
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/66c5b448a008750008604369

@hardfist hardfist changed the title Add more clippy rule refactor: add more clippy rule Aug 16, 2024
@hardfist
Copy link
Contributor Author

!bench

@rspack-bot
Copy link

rspack-bot commented Aug 16, 2024

📝 Benchmark detail: Open

Name Base (2024-08-16 218bda0) Current Change
10000_development-mode + exec 2.35 s ± 21 ms 2.35 s ± 25 ms -0.06 %
10000_development-mode_hmr + exec 713 ms ± 13 ms 713 ms ± 7.5 ms +0.05 %
10000_production-mode + exec 3.02 s ± 38 ms 3.04 s ± 33 ms +0.90 %
arco-pro_development-mode + exec 1.91 s ± 68 ms 1.89 s ± 108 ms -1.41 %
arco-pro_development-mode_hmr + exec 439 ms ± 2 ms 440 ms ± 3.3 ms +0.11 %
arco-pro_production-mode + exec 3.48 s ± 110 ms 3.48 s ± 50 ms +0.26 %
arco-pro_production-mode_generate-package-json-webpack-plugin + exec 3.52 s ± 98 ms 3.54 s ± 87 ms +0.39 %
threejs_development-mode_10x + exec 1.71 s ± 14 ms 1.73 s ± 19 ms +1.16 %
threejs_development-mode_10x_hmr + exec 823 ms ± 9.3 ms 826 ms ± 8.7 ms +0.33 %
threejs_production-mode_10x + exec 5.53 s ± 39 ms 5.55 s ± 30 ms +0.36 %

@h-a-n-a
Copy link
Contributor

h-a-n-a commented Aug 21, 2024

Would you please fix the conflict and let's get it merged first?

@hardfist hardfist force-pushed the add-more-clippy-rule branch from c277516 to 957b874 Compare August 21, 2024 09:09
@hardfist hardfist force-pushed the add-more-clippy-rule branch from 957b874 to 7b2291f Compare August 21, 2024 09:32
Copy link
Contributor

@h-a-n-a h-a-n-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's ship this first

@h-a-n-a h-a-n-a merged commit 82f49ce into main Aug 21, 2024
28 checks passed
@h-a-n-a h-a-n-a deleted the add-more-clippy-rule branch August 21, 2024 09:40
@chenjiahan chenjiahan mentioned this pull request Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants