-
-
Notifications
You must be signed in to change notification settings - Fork 595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: module hash #7569
Merged
Merged
refactor: module hash #7569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
team
The issue/pr is created by the member of Rspack.
label
Aug 14, 2024
✅ Deploy Preview for rspack canceled.
|
ahabhgk
force-pushed
the
refactor-module-hash
branch
from
August 14, 2024 11:29
4cab65e
to
503e26c
Compare
!bench |
📝 Benchmark detail: Open
Threshold exceeded: ["10000_production-mode + exec"] |
ahabhgk
force-pushed
the
refactor-module-hash
branch
from
August 15, 2024 05:22
8b51bb1
to
01caa0c
Compare
LingyuCoder
approved these changes
Aug 15, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
introduce module (chunk graph module) hash to optimize codegen phase when rebuild, this add a new phase
create_module_hashes
to calculate module hashprocess_runtime_requirements
will also use it as cache key in future PRcreate_module_hashes
cause start time slower a bit, but this is necessary and will improve it from other phasesChecklist