Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor!: disable css minify in html minify and remove SwcCssMinimizerRspackPlugin #7547

Merged
merged 5 commits into from
Aug 15, 2024
Merged

refactor!: disable css minify in html minify and remove SwcCssMinimizerRspackPlugin #7547

merged 5 commits into from
Aug 15, 2024

Conversation

ahabhgk
Copy link
Contributor

@ahabhgk ahabhgk commented Aug 13, 2024 •
edited by chenjiahan
Loading

Summary

  • update SWC (swc_core from 0.99 to 0.100)
  • remove SwcCssMinimizerRspackPlugin
  • disable CSS minify in HtmlRspackPlugin minify
  • we will use lightningcss to minify CSS insides HTML in the future
    • for now lightningcss only supports parse stylesheet and style attributes, but for minify html it need to support parse media query (html sizes and imagesizes need this)

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Aug 13, 2024
@netlify Netlify
Copy link

netlify bot commented Aug 13, 2024 •
edited
Loading

✅ Deploy Preview for rspack ready!

Name Link
🔨 Latest commit 2e30aca
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/66bdda6fd9ae1500084058f0
😎 Deploy Preview https://deploy-preview-7547--rspack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ahabhgk ahabhgk force-pushed the remove-html-minify branch from 6147804 to dd814ff Compare August 15, 2024 09:31
@ahabhgk ahabhgk marked this pull request as ready for review August 15, 2024 10:28
@ahabhgk ahabhgk changed the title refactor: remove html minify refactor!: disable css minify in html minify Aug 15, 2024
@ahabhgk ahabhgk changed the title refactor!: disable css minify in html minify refactor!: disable css minify in html minify and remove SwcCssMinimizerRspackPlugin Aug 15, 2024
@ahabhgk ahabhgk requested a review from chenjiahan August 15, 2024 10:38
@chenjiahan chenjiahan added the release: breaking change release: breaking change related release(mr only) label Aug 15, 2024
@ahabhgk ahabhgk merged commit 2bca663 into main Aug 15, 2024
32 checks passed
@ahabhgk ahabhgk deleted the remove-html-minify branch August 15, 2024 10:52
@chenjiahan chenjiahan mentioned this pull request Aug 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenjiahan chenjiahan chenjiahan approved these changes

Assignees

@ahabhgk ahabhgk

Labels
release: breaking change release: breaking change related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahabhgk @chenjiahan