Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(typescript): increase typescript type coverage to 100% for rspack-plugin-react-refresh #7448

Merged

Conversation

shulaoda
Copy link
Collaborator

@shulaoda shulaoda commented Aug 5, 2024

Summary

Related to #7225

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Aug 5, 2024

Deploy Preview for rspack canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit bd17a2b
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/66b0b87f99d70c0008601aef

Copy link
Member

@SoonIter SoonIter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@chenjiahan chenjiahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@chenjiahan chenjiahan merged commit f44c966 into web-infra-dev:main Aug 5, 2024
33 checks passed
@shulaoda shulaoda deleted the refactor/rspack-plugin-react-refresh branch August 5, 2024 12:59
@chenjiahan chenjiahan mentioned this pull request Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants