Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(type): increase type-coverage #7437

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

SoonIter
Copy link
Member

@SoonIter SoonIter commented Aug 5, 2024

Summary

ci(infra/type): add type-coverage

The type coverage of each file needs to be >= 80%

#7225

Copy link

netlify bot commented Aug 5, 2024

Deploy Preview for rspack canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit da897a2
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/66b0837461906e0008181368

@SoonIter SoonIter marked this pull request as ready for review August 5, 2024 07:31
@SoonIter SoonIter requested a review from jerrykingxyz as a code owner August 5, 2024 07:31
@SoonIter SoonIter requested a review from chenjiahan August 5, 2024 07:35
@chenjiahan
Copy link
Member

I think it is better to use Biome to ban any because it executes faster and is more accurate

@SoonIter SoonIter force-pushed the increase-type-coverage branch from d1f8da4 to da897a2 Compare August 5, 2024 07:46
@SoonIter SoonIter changed the title ci(infra/type): add type-coverage refactor(type): increase type-coverage Aug 5, 2024
@chenjiahan chenjiahan enabled auto-merge (squash) August 5, 2024 07:48
@chenjiahan chenjiahan merged commit e6cfc05 into web-infra-dev:main Aug 5, 2024
30 checks passed
@chenjiahan chenjiahan mentioned this pull request Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants