Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: on-demand sourcemap generation #6443

Merged
merged 1 commit into from
May 8, 2024
Merged

perf: on-demand sourcemap generation #6443

merged 1 commit into from
May 8, 2024

Conversation

h-a-n-a
Copy link
Contributor

@h-a-n-a h-a-n-a commented May 6, 2024

Summary

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added the release: performance release: performance related release(mr only) label May 6, 2024
Copy link

netlify bot commented May 6, 2024

Deploy Preview for rspack failed. Why did it fail? →

Name Link
🔨 Latest commit 49d6521
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/6638a7232f482c0008368e3e

@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label May 6, 2024
@h-a-n-a h-a-n-a force-pushed the perf-on-demand-sm branch from db09349 to 49d6521 Compare May 6, 2024 09:47
@h-a-n-a
Copy link
Contributor Author

h-a-n-a commented May 6, 2024

!bench

@rspack-bot
Copy link

rspack-bot commented May 6, 2024

📝 Benchmark detail: Open

task failure

@h-a-n-a
Copy link
Contributor Author

h-a-n-a commented May 6, 2024

!bench

@rspack-bot
Copy link

rspack-bot commented May 6, 2024

📝 Benchmark detail: Open

task failure

@h-a-n-a
Copy link
Contributor Author

h-a-n-a commented May 6, 2024

!bench

@rspack-bot
Copy link

rspack-bot commented May 6, 2024

📝 Benchmark detail: Open

task failure

@h-a-n-a
Copy link
Contributor Author

h-a-n-a commented May 8, 2024

!bench

@rspack-bot
Copy link

rspack-bot commented May 8, 2024

📝 Benchmark detail: Open

Name Base (2024-05-08 65224fb) Current Change
10000_development-mode + exec 2.74 s ± 26 ms 2.76 s ± 23 ms +0.79 %
10000_development-mode_hmr + exec 695 ms ± 20 ms 702 ms ± 7.2 ms +1.01 %
10000_production-mode + exec 2.51 s ± 26 ms 2.55 s ± 26 ms +1.67 %
arco-pro_development-mode + exec 2.51 s ± 50 ms 2.51 s ± 83 ms +0.04 %
arco-pro_development-mode_hmr + exec 430 ms ± 2 ms 430 ms ± 2.4 ms +0.06 %
arco-pro_development-mode_hmr_intercept-plugin + exec 440 ms ± 1.6 ms 442 ms ± 6.1 ms +0.40 %
arco-pro_development-mode_intercept-plugin + exec 3.33 s ± 84 ms 3.3 s ± 50 ms -0.66 %
arco-pro_production-mode + exec 4.03 s ± 93 ms 4.05 s ± 111 ms +0.30 %
arco-pro_production-mode_intercept-plugin + exec 4.84 s ± 81 ms 4.9 s ± 60 ms +1.10 %
threejs_development-mode_10x + exec 2 s ± 22 ms 2.04 s ± 13 ms +2.04 %
threejs_development-mode_10x_hmr + exec 768 ms ± 8.4 ms 771 ms ± 8.2 ms +0.34 %
threejs_production-mode_10x + exec 5.18 s ± 18 ms 5.23 s ± 25 ms +1.10 %

@h-a-n-a h-a-n-a marked this pull request as ready for review May 8, 2024 07:21
@h-a-n-a h-a-n-a requested a review from jerrykingxyz as a code owner May 8, 2024 07:21
@h-a-n-a h-a-n-a enabled auto-merge (squash) May 8, 2024 07:31
@h-a-n-a h-a-n-a merged commit 025b32c into main May 8, 2024
36 of 40 checks passed
@h-a-n-a h-a-n-a deleted the perf-on-demand-sm branch May 8, 2024 07:31
@pushkargupta9807
Copy link

can we please have more info on this perf improvement PR ? For instance how can we use it , examples etc

@chenjiahan
Copy link
Member

@h-a-n-a please check this ⬆️

@h-a-n-a
Copy link
Contributor Author

h-a-n-a commented May 13, 2024

can we please have more info on this perf improvement PR ? For instance how can we use it , examples etc

This is an internal optimisation where source maps should always be generated on-demand by builtin:swc-loader with the respect to the compiler's source map options. I didn't make a real world benchmark, but this will improve the case where options.devtool set to false.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: performance release: performance related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants