Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(config): support snapshot config {timestamp: true} and {hash: true} #6399

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

SoonIter
Copy link
Member

@SoonIter SoonIter commented Apr 29, 2024

Summary

#6381 #6387

{ hash: true } { timestamp: true } and { timestamp: true, hash: true } should be three different behaviors.
I think this is a very misleading configuration.

https://webpack.js.org/configuration/other-options/#builddependencies

image

cases

{} and { timestamp: false, hash: false } -> { timestamp: false, hash: false }
{ hash: true } -> { timestamp: false, hash: true }
{ timestamp: true } -> { timestamp: true, hash: false }
{ timestamp: true, hash: true }

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added the release: bug fix release: bug related release(mr only) label Apr 29, 2024
Copy link

netlify bot commented Apr 29, 2024

Deploy Preview for rspack canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit 14182bf
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/662f5c7f6cf47700085782f8

Copy link
Contributor

@ahabhgk ahabhgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, bro

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: bug fix release: bug related release(mr only)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants