Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: default resolve roots #6340

Merged
merged 6 commits into from
Apr 25, 2024
Merged

fix: default resolve roots #6340

merged 6 commits into from
Apr 25, 2024

Conversation

ahabhgk
Copy link
Contributor

@ahabhgk ahabhgk commented Apr 23, 2024 •
edited
Loading

Summary

fix #6332

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added the release: bug fix release: bug related release(mr only) label Apr 23, 2024
@netlify Netlify
Copy link

netlify bot commented Apr 23, 2024 •
edited
Loading

✅ Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 53e6db3
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/6629e583e984400008a2a059

@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Apr 23, 2024
@ahabhgk ahabhgk mentioned this pull request Apr 24, 2024
Merged
@Boshen
Copy link
Contributor

Boshen commented Apr 24, 2024

Can you try oxc_resolver = { git = "https://github.com/oxc-project/oxc-resolver.git", branch = "next" } before I make a release?

@ahabhgk ahabhgk force-pushed the fix-resolve-roots branch from 748ce9b to dd4294f Compare April 24, 2024 07:48
@ahabhgk ahabhgk marked this pull request as ready for review April 24, 2024 07:50
@Boshen Boshen self-requested a review April 24, 2024 11:52
@ahabhgk ahabhgk enabled auto-merge (squash) April 25, 2024 05:21
@ahabhgk ahabhgk merged commit 549825a into main Apr 25, 2024
33 checks passed
@ahabhgk ahabhgk deleted the fix-resolve-roots branch April 25, 2024 05:58
@ahabhgk ahabhgk mentioned this pull request Apr 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Boshen Boshen Boshen approved these changes

Assignees

@ahabhgk ahabhgk

Labels
release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: require.context error. should have dependency id
2 participants
@ahabhgk @Boshen