Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support custom source root #5522

Merged
merged 10 commits into from
Feb 1, 2024
Merged

Conversation

SyMind
Copy link
Member

@SyMind SyMind commented Jan 30, 2024

Fix: #3862
Relying on PRs: web-infra-dev/rspack-sources#83 , web-infra-dev/rspack-sources#84 , web-infra-dev/rspack-sources#85

Summary

Test Plan

Require Documentation?

  • No
  • Yes, the corresponding rspack-website PR is __

@github-actions github-actions bot added the release: feature release: feature related release(mr only) label Jan 30, 2024
@SyMind SyMind marked this pull request as ready for review February 1, 2024 06:13
@SyMind SyMind requested a review from hardfist as a code owner February 1, 2024 06:13
@SyMind
Copy link
Member Author

SyMind commented Feb 1, 2024

!bench

@rspack-bot
Copy link

rspack-bot commented Feb 1, 2024

📝 Benchmark detail: Open

Name Base (2024-02-01 e4dc2f4) Current Change
10000_development-mode + exec 1.7 s ± 14 ms 1.67 s ± 19 ms -1.93 %
10000_development-mode_hmr + exec 950 ms ± 10 ms 921 ms ± 15 ms -3.04 %
10000_production-mode + exec 2.75 s ± 46 ms 2.62 s ± 17 ms -4.96 %
arco-pro_development-mode + exec 2.69 s ± 32 ms 2.67 s ± 50 ms -0.78 %
arco-pro_development-mode_hmr + exec 1.09 s ± 16 ms 1.07 s ± 40 ms -2.17 %
arco-pro_production-mode + exec 4.29 s ± 57 ms 4.23 s ± 67 ms -1.24 %
threejs_development-mode_10x + exec 1.99 s ± 25 ms 1.9 s ± 19 ms -4.34 %
threejs_development-mode_10x_hmr + exec 1.23 s ± 14 ms 1.13 s ± 6.9 ms -8.25 %
threejs_production-mode_10x + exec 5.81 s ± 40 ms 5.63 s ± 27 ms -3.19 %

@SyMind SyMind merged commit fe785af into web-infra-dev:main Feb 1, 2024
20 checks passed
jerrykingxyz pushed a commit that referenced this pull request Feb 1, 2024
Revert "feat: support custom source root (#5522)"

This reverts commit fe785af.
@SyMind SyMind mentioned this pull request Feb 2, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: feature release: feature related release(mr only)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support emitting sourceRoot in generated source map
3 participants