feat(rspack_core): configurable tsconfig project references

[Boshen]

closes #4211

• Bump version for fix(resolver): resolve tsconfig extend that are extensionless oxc-project/oxc#971

Summary

See #4211 for background.

This PR aligns the tsconfig option with https://github.com/dividab/tsconfig-paths-webpack-plugin#options

The original resolve#tsConfigPath option is not removed nor deprecated in this PR.

For better ux, the tsconfig#references option has an additional auto value where the values of project references can be automatically picked up from tsconfig.json.

Test Plan

Two test cases are added to rspack tests:

• packages/rspack/tests/configCases/resolve-new/tsconfig-project-references-auto: uses project references defined in tsconfig.json
• packages/rspack/tests/configCases/resolve-new/tsconfig-project-references-manual: uses project references defined in webpack.config.js#resolve#references.

Require Documentation?

• No
• Yes, the corresponding rspack-website PR is TODO @Boshen

[hardfist]

!canary

[hardfist]

@chenjiahan can you help test it in modernjs sourceBuild tests

[chenjiahan]

I'd love to, can you provide a canary version?

[chenjiahan]

Or you can merge it and we will test it tomorrow.

[github-actions]

0.3.6-canary-9cae447-20231008135313

[hardfist]

0.3.6-canary-9cae447-20231008135313

here you are @chenjiahan

[chenjiahan]

I'm trying to use the new resolver and references in Modern.js, but I got this error:

@Boshen can you help to figure it out?

Reproduce steps:

git clone [email protected]:web-infra-dev/modern.js.git

git checkout tsconfig_references_1009

pnpm i

cd tests/integration/source-code-build/app

PROVIDE_TYPE=rspack pnpm dev

[Boshen]

@chenjiahan There is a small bug related to resolving extends, try "extends": "@modern-js/tsconfig/base.json" for the meantime while I patch a fix.

After this is fixed, it shows that react/jsx-dev-runtime cannot be resolved:

This is due to react being installed in source-code-build/app/node_modules, so it won't be found in source-code-build/components.

[chenjiahan]

This is due to react being installed in source-code-build/app/node_modules, so it won't be found in source-code-build/components.

Got it, but when Modern.js using webpack, the react/jsx-dev-runtime can be resolved correctly, i have no idea why it can work...

[Boshen]

@chenjiahan Is it because you specified "@source-code-build/components": "workspace:*" in your package.json#dependencies so it read the import @source-code-build/components from source-code-build/app/node_modules/@source-code-build/components/src/card/index.tsx instead of source-code-build/components/src/card/index.tsx?

I'm not really up to date around workspace dependencies and project references ...

[chenjiahan]

When using workspace:*, the package is linked by symlink, so it should be resolved to the real path by default (according to https://webpack.js.org/configuration/resolve/#resolvesymlinks)

[Boshen]

@chenjiahan I ran pnpm dev and it threw

File: ./src/App.tsx
Module not found: Can't resolve '@source-code-build/components' in '/Users/bytedance/github/modern.js/tests/integration/source-code-build/app/src'

How did you make it run successfully with webpack?

[chenjiahan]

Yes it can work in webpack. You need to enable the following config:

Or just checkout to the master branch of modern.js.

[Boshen]

@chenjiahan webpack works because the app's node_modules directory is manually added to resolve#modules.

If you print out normalizedOptions.modules from enhanced-resolve located in node_modules/.pnpm/[email protected]/node_modules/enhanced-resolve/lib/ResolverFactory.js, you get

[
  'node_modules',
  '/Users/bytedance/github/modern.js/tests/integration/source-code-build/app/node_modules'
]

This resolver#modules value is not passed to Rspack's resolve option so it didn't build successfully. I verified this manually by adding it to rspack#resolve and it builds successfully.

[chenjiahan]

Nice catch! This is a difference between the webpack and rspack modes of modern.js, I will fix it.

[Boshen]

Are there any more blockers?

[chenjiahan]

Time to merge! I will do some more testing later.