Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add builtins.react/... only works for transformByDefault tip #4249

Merged
merged 5 commits into from
Sep 26, 2023

Conversation

9aoy
Copy link
Contributor

@9aoy 9aoy commented Sep 26, 2023

image

Summary

Test Plan

Require Documentation?

  • No
  • Yes, the corresponding rspack-website PR is __

@9aoy 9aoy requested review from a team, LingyuCoder and ahabhgk September 26, 2023 02:29
@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Sep 26, 2023
@9aoy 9aoy requested a review from h-a-n-a September 26, 2023 02:30
@9aoy 9aoy changed the title chore: add deprecatedWarn for builtins.react/... when disableTransformByDefault chore: add builtins.react/... only works for transformByDefault tip Sep 26, 2023
h-a-n-a
h-a-n-a previously approved these changes Sep 26, 2023
@9aoy 9aoy enabled auto-merge September 26, 2023 06:03
@9aoy 9aoy added this pull request to the merge queue Sep 26, 2023
Merged via the queue into main with commit ddb16e4 Sep 26, 2023
@9aoy 9aoy deleted the deprecated-builtin-transform branch September 26, 2023 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants