Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support object external item value #4234

Merged
merged 2 commits into from
Sep 25, 2023
Merged

feat: support object external item value #4234

merged 2 commits into from
Sep 25, 2023

Conversation

ahabhgk
Copy link
Contributor

@ahabhgk ahabhgk commented Sep 22, 2023 •
edited
Loading

Summary

resolve #4060

Test Plan

  • added

Require Documentation?

@ahabhgk ahabhgk requested review from a team September 22, 2023 11:52
@ahabhgk ahabhgk requested a review from h-a-n-a as a code owner September 22, 2023 11:52
@github-actions github-actions bot added release: feature team The issue/pr is created by the member of Rspack. labels Sep 22, 2023
@ahabhgk ahabhgk added this pull request to the merge queue Sep 25, 2023
Merged via the queue into main with commit f816657 Sep 25, 2023
17 checks passed
@ahabhgk ahabhgk deleted the feat-external-obj branch September 25, 2023 09:06
@hardfist hardfist added the release: feature release: feature related release(mr only) label Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hyf0 hyf0 hyf0 approved these changes

@h-a-n-a h-a-n-a Awaiting requested review from h-a-n-a

@LingyuCoder LingyuCoder Awaiting requested review from LingyuCoder

@ScriptedAlchemy ScriptedAlchemy Awaiting requested review from ScriptedAlchemy

Assignees
No one assigned
Labels
release: feature release: feature related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

externals 配置在umd模式下编译报错
3 participants
@ahabhgk @hyf0 @hardfist