Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support include and exclude of react-refresh-rspack-plugin #4233

Merged
merged 1 commit into from
Sep 22, 2023
Merged

feat: support include and exclude of react-refresh-rspack-plugin #4233

merged 1 commit into from
Sep 22, 2023

Conversation

h-a-n-a
Copy link
Contributor

@h-a-n-a h-a-n-a commented Sep 22, 2023 •
edited
Loading

Summary

  • Add react-refresh-entry to the loader excluding list
  • Support passing include or exclude of plugin

Test Plan

Added

Require Documentation?

  • No
  • Yes, the corresponding rspack-website PR is , let's create a page for rspack plugins first.

@github-actions github-actions bot added release: feature team The issue/pr is created by the member of Rspack. labels Sep 22, 2023
@h-a-n-a h-a-n-a added the need documentation Create a tracking issue in rspack-website label Sep 22, 2023
@h-a-n-a h-a-n-a marked this pull request as ready for review September 22, 2023 09:52
@h-a-n-a h-a-n-a requested a review from Boshen as a code owner September 22, 2023 09:52
@h-a-n-a h-a-n-a requested a review from ahabhgk September 22, 2023 09:53
@h-a-n-a h-a-n-a added this pull request to the merge queue Sep 22, 2023
Merged via the queue into main with commit 25b34ba Sep 22, 2023
20 checks passed
@h-a-n-a h-a-n-a deleted the feat/react-refresh-path branch September 22, 2023 11:36
@hardfist hardfist added the release: feature release: feature related release(mr only) label Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahabhgk ahabhgk ahabhgk approved these changes

@Boshen Boshen Awaiting requested review from Boshen

Assignees
No one assigned
Labels
need documentation Create a tracking issue in rspack-website release: feature release: feature related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@h-a-n-a @ahabhgk @hardfist