Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add side effects detect #4215

Merged
merged 24 commits into from
Sep 21, 2023
Merged

Conversation

IWANABETHATGUY
Copy link
Contributor

@IWANABETHATGUY IWANABETHATGUY commented Sep 18, 2023

Summary

  1. 33 /75 tests passed.
  2. enable SideEffectsFlagPlugin

Test Plan

Require Documentation?

  • No
  • Yes, the corresponding rspack-website PR is __

@IWANABETHATGUY IWANABETHATGUY force-pushed the feat/add-side-effects-detect branch from 881e518 to 464cfea Compare September 19, 2023 06:38
@IWANABETHATGUY IWANABETHATGUY changed the title Feat/add side effects detect feat: add side effects detect Sep 20, 2023
@IWANABETHATGUY IWANABETHATGUY force-pushed the feat/add-side-effects-detect branch from 70f16d6 to f900cfa Compare September 21, 2023 02:35
@IWANABETHATGUY IWANABETHATGUY marked this pull request as ready for review September 21, 2023 04:33
@IWANABETHATGUY IWANABETHATGUY added this pull request to the merge queue Sep 21, 2023
Merged via the queue into main with commit d6072e5 Sep 21, 2023
15 checks passed
@IWANABETHATGUY IWANABETHATGUY deleted the feat/add-side-effects-detect branch September 21, 2023 05:43
@hardfist hardfist added the release: feature release: feature related release(mr only) label Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: feature release: feature related release(mr only)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants