Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: eagerly calculate source-map #4212

Closed
wants to merge 1 commit into from
Closed

perf: eagerly calculate source-map #4212

wants to merge 1 commit into from

Conversation

h-a-n-a
Copy link
Contributor

@h-a-n-a h-a-n-a commented Sep 18, 2023

Summary

Test Plan

No need.

Require Documentation?

  • No
  • Yes, the corresponding rspack-website PR is __

@h-a-n-a h-a-n-a requested review from a team, LingyuCoder and jerrykingxyz September 18, 2023 10:04
@h-a-n-a h-a-n-a marked this pull request as draft September 18, 2023 10:05
@h-a-n-a
Copy link
Contributor Author

h-a-n-a commented Sep 18, 2023

!bench

@github-actions github-actions bot added release: performance team The issue/pr is created by the member of Rspack. labels Sep 18, 2023
@rspack-bot
Copy link

rspack-bot commented Sep 18, 2023

📝 Benchmark detail: Open

name base current %
10000_development-mode + exec 1.41 s ± 15 ms 1.62 s ± 14 ms +14.81%
10000_development-mode_hmr + exec 957 ms ± 11 ms 1.13 s ± 9.5 ms +18.55%
10000_production-mode + exec 3.4 s ± 43 ms 3.49 s ± 20 ms +2.83%
threejs_development-mode_10x + exec 1.58 s ± 12 ms 2.13 s ± 17 ms +35.24%
threejs_development-mode_10x_hmr + exec 967 ms ± 8 ms 1.43 s ± 5.6 ms +48.40%
threejs_production-mode_10x + exec 5.64 s ± 18 ms 6.08 s ± 43 ms +7.93%

Threshold exceeded: ["10000_development-mode + exec","10000_development-mode_hmr + exec","threejs_development-mode_10x + exec","threejs_development-mode_10x_hmr + exec","threejs_production-mode_10x + exec"]

@h-a-n-a
Copy link
Contributor Author

h-a-n-a commented Sep 19, 2023

This should be better done parallel in the rspack-sources itself. So I decide to close it.

@h-a-n-a h-a-n-a closed this Sep 19, 2023
@LingyuCoder LingyuCoder reopened this Sep 26, 2023
@h-a-n-a h-a-n-a deleted the perf/source-map branch June 18, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants