Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: remove panic_hook #4210

Merged
merged 1 commit into from
Sep 19, 2023
Merged

perf: remove panic_hook #4210

merged 1 commit into from
Sep 19, 2023

Conversation

h-a-n-a
Copy link
Contributor

@h-a-n-a h-a-n-a commented Sep 18, 2023 •
edited
Loading

Summary

Remove panic_hook to avoid lock contentions.
take_hook and set_hook needs to acquire locks.
Let's not distinguish whether a panic needs to be suppressed.

Test Plan

No need.

Require Documentation?

  • No
  • Yes, the corresponding rspack-website PR is __

@h-a-n-a h-a-n-a requested review from a team, LingyuCoder and jerrykingxyz September 18, 2023 09:07
@github-actions github-actions bot added release: performance team The issue/pr is created by the member of Rspack. labels Sep 18, 2023
@h-a-n-a

This comment was marked as outdated.

Sign in to view
@rspack-bot

This comment was marked as outdated.

Sign in to view
@h-a-n-a h-a-n-a marked this pull request as draft September 18, 2023 09:35
@h-a-n-a
Copy link
Contributor Author

h-a-n-a commented Sep 19, 2023

!bench

@rspack-bot
Copy link

rspack-bot commented Sep 19, 2023 •
edited
Loading

📝 Benchmark detail: Open

name base current %
10000_development-mode + exec 1.58 s ± 14 ms 1.57 s ± 13 ms -0.41%
10000_development-mode_hmr + exec 1.13 s ± 13 ms 1.12 s ± 14 ms -0.35%
10000_production-mode + exec 3.56 s ± 35 ms 3.44 s ± 21 ms -3.21%
threejs_development-mode_10x + exec 2.08 s ± 19 ms 2.05 s ± 24 ms -1.39%
threejs_development-mode_10x_hmr + exec 1.42 s ± 9.8 ms 1.42 s ± 6.7 ms -0.15%
threejs_production-mode_10x + exec 6.19 s ± 20 ms 6.03 s ± 39 ms -2.58%

@h-a-n-a h-a-n-a marked this pull request as ready for review September 19, 2023 03:44
@h-a-n-a h-a-n-a requested a review from ahabhgk September 19, 2023 03:44
@h-a-n-a h-a-n-a added this pull request to the merge queue Sep 19, 2023
Merged via the queue into main with commit 147193f Sep 19, 2023
20 checks passed
@h-a-n-a h-a-n-a deleted the perf/remove-panic-hook branch September 19, 2023 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerrykingxyz jerrykingxyz jerrykingxyz approved these changes

@LingyuCoder LingyuCoder Awaiting requested review from LingyuCoder

@ahabhgk ahabhgk Awaiting requested review from ahabhgk

Assignees
No one assigned
Labels
team The issue/pr is created by the member of Rspack.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@h-a-n-a @rspack-bot @jerrykingxyz