Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: change method on ExportsInfoId align to webpack #4209

Merged
merged 3 commits into from
Sep 18, 2023

Conversation

IWANABETHATGUY
Copy link
Contributor

@IWANABETHATGUY IWANABETHATGUY commented Sep 18, 2023

Summary

  1. Due to we have changed ExportInfo based on Id and moduleGraph, so we don't need to use an iterator-based method rewrite, using a recursive-based method is more like webpack, which is easier to understand.

Test Plan

Require Documentation?

  • No
  • Yes, the corresponding rspack-website PR is __

@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Sep 18, 2023
@IWANABETHATGUY IWANABETHATGUY marked this pull request as ready for review September 18, 2023 08:46
@IWANABETHATGUY IWANABETHATGUY added this pull request to the merge queue Sep 18, 2023
Merged via the queue into main with commit 54d8d61 Sep 18, 2023
18 checks passed
@IWANABETHATGUY IWANABETHATGUY deleted the refactor/iter-to-webpack-based branch September 18, 2023 10:13
IWANABETHATGUY added a commit that referenced this pull request Sep 18, 2023
* chore: 🤖 init

* chore: 🤖 refactor

* chore: 🤖 lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants