Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: pass more tree shaking test case #4191

Merged
merged 27 commits into from
Sep 17, 2023
Merged

test: pass more tree shaking test case #4191

merged 27 commits into from
Sep 17, 2023

Conversation

IWANABETHATGUY
Copy link
Contributor

@IWANABETHATGUY IWANABETHATGUY commented Sep 14, 2023 •
edited
Loading

Summary

  1. refine simple test framework.
  2. pass more tree shaking test case.

Test Plan

Require Documentation?

  • No
  • Yes, the corresponding rspack-website PR is __

@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Sep 14, 2023
@IWANABETHATGUY IWANABETHATGUY force-pushed the test/more-tree-shaking-test1 branch 2 times, most recently from 1ced7f2 to 989393f Compare September 15, 2023 02:28
@IWANABETHATGUY IWANABETHATGUY changed the title Test/more tree shaking test1 test: pass more tree shaking test case Sep 15, 2023
@IWANABETHATGUY IWANABETHATGUY force-pushed the test/more-tree-shaking-test1 branch from 0ae49cf to 94bf0b6 Compare September 15, 2023 03:37
@IWANABETHATGUY IWANABETHATGUY force-pushed the test/more-tree-shaking-test1 branch from 94bf0b6 to 8303646 Compare September 16, 2023 13:57
@IWANABETHATGUY IWANABETHATGUY marked this pull request as ready for review September 17, 2023 13:23
@IWANABETHATGUY IWANABETHATGUY requested review from a team September 17, 2023 13:23
@underfin underfin enabled auto-merge September 17, 2023 14:13
@underfin underfin added this pull request to the merge queue Sep 17, 2023
Merged via the queue into main with commit 9d910ae Sep 17, 2023
13 checks passed
@underfin underfin deleted the test/more-tree-shaking-test1 branch September 17, 2023 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@underfin underfin underfin approved these changes

@ahabhgk ahabhgk Awaiting requested review from ahabhgk

@h-a-n-a h-a-n-a Awaiting requested review from h-a-n-a

@ScriptedAlchemy ScriptedAlchemy Awaiting requested review from ScriptedAlchemy

Assignees
No one assigned
Labels
team The issue/pr is created by the member of Rspack.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@IWANABETHATGUY @underfin