feat: inner graph part one

crates/node_binding/binding.d.ts

@@ -853,6 +853,7 @@ export interface RawOptimizationOptions {
   sideEffects: string
   usedExports: string
   providedExports: boolean
+  innerGraph: boolean
   realContentHash: boolean
 }
 

crates/rspack/tests/check.js

@@ -3,8 +3,7 @@ const fs = require("fs");
 
 const currentDir = path.resolve(__dirname, "./tree-shaking");
 const dirList = fs.readdirSync(currentDir);
-const excludeList = ["node_modules"]
-
+const excludeList = ["node_modules"];
 
 const filteredList = dirList.filter((dir) => {
 	if (dir.startsWith(".")) {
@@ -17,19 +16,47 @@ const filteredList = dirList.filter((dir) => {
 	return true;
 });
 
-console.log(`total: ${filteredList.length}`)
+console.log(`total: ${filteredList.length}`);
 
-const falsePositiveList = [
-	'cjs-export-computed-property', // This one is false positive because webpack will not counted a esm export as unsed in an entry module, the previous implementation follows the esbuild behavior , see https://gist.github.com/IWANABETHATGUY/b41d0f80a558580010276a44b310a473
-]
-const failedList = filteredList.filter(item => {
-	if (falsePositiveList.includes(item)) {
-		return false;
-	}
-	const abPath = path.join(currentDir, item, "snapshot", "snap.diff")
-	return fs.existsSync(abPath)
-})
+const falsePositiveMap = {
+	"cjs-export-computed-property":
+		"This one is false positive because webpack will not counted a esm export as unsed in an entry module, the previous implementation follows the esbuild behavior , see https://gist.github.com/IWANABETHATGUY/b41d0f80a558580010276a44b310a473",
+	basic: "align webpack unused binding behavior",
+	"context-module-elimated": "align webpack unused binding behavior",
+	"rollup-unused-called-import": "align webpack unused binding behavior",
+	"var-function-expr": "align webpack unused binding behavior",
+	"webpack-innergraph-no-side-effects": "align webpack unused binding behavior",
+	"side-effects-export-default-expr": "align webpack unused binding behavior"
+};
+
+const normalizedList = filteredList.map((item) => {
+	const abPath = path.join(currentDir, item, "snapshot", "snap.diff");
+	let status = fs.existsSync(abPath);
+	return {
+		name: item,
+		reason: falsePositiveMap[item],
+		passed: !status,
+	};
+});
+
+let successedCount = normalizedList.filter((item) => {
+	return item.passed || !!item.reason;
+}).length;
+
+let fasePositiveCases = normalizedList
+	.filter((item) => {
+		return !!item.reason;
+	})
+	.map((item) => {
+		return `${item.name}: ${item.reason}`;
+	});
+let failedCases = normalizedList
+	.filter((item) => !item.passed && !item.reason)
+	.map((item) => {
+		return item.name;
+	});
 
-console.log(`failed: ${failedList.length}`)
-console.log(`passed: ${filteredList.length - failedList.length}`)
-console.log('failed list:\n', failedList)
+console.log(`failed: ${filteredList.length - successedCount}`);
+console.log(`passed: ${successedCount}`);
+console.log(`fasePositiveCases: ${fasePositiveCases.length}\n`, fasePositiveCases);
+console.log(`failedCases: ${failedCases.length}\n`, failedCases);

crates/rspack/tests/fixtures.rs

@@ -25,7 +25,7 @@ fn samples(fixture_path: PathBuf) {
 fn tree_shaking(fixture_path: PathBuf) {
   // For each test case
   // First test is old version tree shaking snapshot test
-  test_fixture(&fixture_path, Box::new(|_, _| {}), None);
+  // test_fixture(&fixture_path, Box::new(|_, _| {}), None);
   // second test is webpack based tree shaking
   IS_NEW_TREESHAKING.store(true, Ordering::SeqCst);
   test_fixture(
@@ -34,6 +34,7 @@ fn tree_shaking(fixture_path: PathBuf) {
       |plugins: &mut Vec<BoxPlugin>, options: &mut CompilerOptions| {
         options.experiments.rspack_future.new_treeshaking = true;
         options.optimization.provided_exports = true;
+        options.optimization.inner_graph = true;
         options.optimization.used_exports = UsedExportsOption::True;
         options.builtins.tree_shaking = TreeShaking::False;
 

crates/rspack/tests/tree-shaking/basic/snapshot/new_treeshaking.snap

@@ -22,7 +22,7 @@ setTimeout(()=>{
  function render() {
     function test() {
         const container = document.getElementById("root");
-        container.innerHTML = `adddd333:${_lib__WEBPACK_IMPORTED_MODULE_0_.secret}:${_lib__WEBPACK_IMPORTED_MODULE_0_.myanswer}`;
+        container.innerHTML = `adddd333:${secret}:${myanswer}`;
     }
 }
 if (module.hot?.accept) module.hot.accept((module1)=>{
@@ -39,7 +39,6 @@ __webpack_require__.r(__webpack_exports__);
 'use strict';
 __webpack_require__.r(__webpack_exports__);
 __webpack_require__.d(__webpack_exports__, {
-  'secret': function() { return secret; },
   'myanswer': function() { return myanswer; }
 });
 /* harmony import */var _answer__WEBPACK_IMPORTED_MODULE_0_ = __webpack_require__(/* ./answer */"./answer.js");

crates/rspack/tests/tree-shaking/basic/snapshot/snap.diff

@@ -5,15 +5,7 @@
      function test() {
          const container = document.getElementById("root");
 -        container.innerHTML = `adddd333:${/* "./lib" unused */null}:${_lib__WEBPACK_IMPORTED_MODULE_0_.myanswer}`;
-+        container.innerHTML = `adddd333:${_lib__WEBPACK_IMPORTED_MODULE_0_.secret}:${_lib__WEBPACK_IMPORTED_MODULE_0_.myanswer}`;
++        container.innerHTML = `adddd333:${secret}:${myanswer}`;
      }
  }
  if (module.hot?.accept) module.hot.accept((module1)=>{
-@@ -39,6 +39,7 @@
- 'use strict';
- __webpack_require__.r(__webpack_exports__);
- __webpack_require__.d(__webpack_exports__, {
-+  'secret': function() { return secret; },
-   'myanswer': function() { return myanswer; }
- });
- /* harmony import */var _answer__WEBPACK_IMPORTED_MODULE_0_ = __webpack_require__(/* ./answer */"./answer.js");

crates/rspack/tests/tree-shaking/class-extend/snapshot/new_treeshaking.snap

@@ -15,7 +15,7 @@ __webpack_require__.d(__webpack_exports__, {
 }
 function foo() {
     return {
-        OriginLib: _lib__WEBPACK_IMPORTED_MODULE_0_.Lib
+        OriginLib
     };
 }
  const v = _lib__WEBPACK_IMPORTED_MODULE_0_.value;

crates/rspack/tests/tree-shaking/class-extend/snapshot/snap.diff

@@ -10,7 +10,7 @@
  function foo() {
      return {
 -        OriginLib: /* "./lib" unused */null
-+        OriginLib: _lib__WEBPACK_IMPORTED_MODULE_0_.Lib
++        OriginLib
      };
  }
   const v = _lib__WEBPACK_IMPORTED_MODULE_0_.value;

crates/rspack/tests/tree-shaking/context-module-elimated/snapshot/new_treeshaking.snap

@@ -3,66 +3,14 @@ source: crates/rspack_testing/src/run_fixture.rs
 ---
 ```js title=main.js
 (self['webpackChunkwebpack'] = self['webpackChunkwebpack'] || []).push([["main"], {
-"./child/child/index.js": function (__unused_webpack_module, __webpack_exports__, __webpack_require__) {
-'use strict';
-__webpack_require__.r(__webpack_exports__);
-__webpack_require__.d(__webpack_exports__, {
-  'value': function() { return value; }
-});
- const value = "dynamic";
-},
-"./child/index.js": function (__unused_webpack_module, __webpack_exports__, __webpack_require__) {
-'use strict';
-__webpack_require__.r(__webpack_exports__);
-__webpack_require__.d(__webpack_exports__, {
-  'value': function() { return value; }
-});
- const value = "dynamic";
-},
-"./child Sync  recursive ^\\.\\/.*\\.js$": function (module, exports, __webpack_require__) {
-var map = {"./child/index.js": "./child/child/index.js","./index.js": "./child/index.js",};
-function webpackContext(req) {
-var id = webpackContextResolve(req);
-
-return __webpack_require__(id);
-
-}
-function webpackContextResolve(req) {
-
-      if(!__webpack_require__.o(map, req)) {
-        var e = new Error("Cannot find module '" + req + "'");
-        e.code = 'MODULE_NOT_FOUND';
-        throw e;
-      }
-      return map[req];
-
-}
-webpackContext.id = '"./child Sync  recursive ^\\.\\/.*\\.js$"';
-
-      webpackContext.keys = function webpackContextKeys() {
-        return Object.keys(map);
-      };
-      webpackContext.resolve = webpackContextResolve;
-      module.exports = webpackContext;
-      },
 "./index.js": function (__unused_webpack_module, __webpack_exports__, __webpack_require__) {
 'use strict';
 __webpack_require__.r(__webpack_exports__);
-/* harmony import */var _lib_js__WEBPACK_IMPORTED_MODULE_0_ = __webpack_require__(/* ./lib.js */"./lib.js");
 
 function test() {
-    _lib_js__WEBPACK_IMPORTED_MODULE_0_.a;
+    a;
 }
 },
-"./lib.js": function (__unused_webpack_module, __webpack_exports__, __webpack_require__) {
-'use strict';
-__webpack_require__.r(__webpack_exports__);
-__webpack_require__.d(__webpack_exports__, {
-  'a': function() { return a; }
-});
- const a = "";
-__webpack_require__(/* ./child */"./child Sync  recursive ^\\.\\/.*\\.js$")((`./child/${a}.js`).replace('./child/', './'));
-},
 
 },function(__webpack_require__) {
 var __webpack_exec__ = function(moduleId) { return __webpack_require__(__webpack_require__.s = moduleId) }

crates/rspack/tests/tree-shaking/context-module-elimated/snapshot/snap.diff

@@ -1,70 +1,11 @@
 --- expected
 +++ actual
-@@ -3,14 +3,66 @@
- ---
- ```js title=main.js
- (self['webpackChunkwebpack'] = self['webpackChunkwebpack'] || []).push([["main"], {
-+"./child/child/index.js": function (__unused_webpack_module, __webpack_exports__, __webpack_require__) {
-+'use strict';
-+__webpack_require__.r(__webpack_exports__);
-+__webpack_require__.d(__webpack_exports__, {
-+  'value': function() { return value; }
-+});
-+ const value = "dynamic";
-+},
-+"./child/index.js": function (__unused_webpack_module, __webpack_exports__, __webpack_require__) {
-+'use strict';
-+__webpack_require__.r(__webpack_exports__);
-+__webpack_require__.d(__webpack_exports__, {
-+  'value': function() { return value; }
-+});
-+ const value = "dynamic";
-+},
-+"./child Sync  recursive ^\\.\\/.*\\.js$": function (module, exports, __webpack_require__) {
-+var map = {"./child/index.js": "./child/child/index.js","./index.js": "./child/index.js",};
-+function webpackContext(req) {
-+var id = webpackContextResolve(req);
-+
-+return __webpack_require__(id);
-+
-+}
-+function webpackContextResolve(req) {
-+
-+      if(!__webpack_require__.o(map, req)) {
-+        var e = new Error("Cannot find module '" + req + "'");
-+        e.code = 'MODULE_NOT_FOUND';
-+        throw e;
-+      }
-+      return map[req];
-+    
-+}
-+webpackContext.id = '"./child Sync  recursive ^\\.\\/.*\\.js$"';
-+
-+      webpackContext.keys = function webpackContextKeys() {
-+        return Object.keys(map);
-+      };
-+      webpackContext.resolve = webpackContextResolve;
-+      module.exports = webpackContext;
-+      },
- "./index.js": function (__unused_webpack_module, __webpack_exports__, __webpack_require__) {
- 'use strict';
+@@ -8,7 +8,7 @@
  __webpack_require__.r(__webpack_exports__);
-+/* harmony import */var _lib_js__WEBPACK_IMPORTED_MODULE_0_ = __webpack_require__(/* ./lib.js */"./lib.js");
 
  function test() {
 -    /* "./lib.js" unused */null;
-+    _lib_js__WEBPACK_IMPORTED_MODULE_0_.a;
++    a;
  }
  },
-+"./lib.js": function (__unused_webpack_module, __webpack_exports__, __webpack_require__) {
-+'use strict';
-+__webpack_require__.r(__webpack_exports__);
-+__webpack_require__.d(__webpack_exports__, {
-+  'a': function() { return a; }
-+});
-+ const a = "";
-+__webpack_require__(/* ./child */"./child Sync  recursive ^\\.\\/.*\\.js$")((`./child/${a}.js`).replace('./child/', './'));
-+},
 
- },function(__webpack_require__) {
- var __webpack_exec__ = function(moduleId) { return __webpack_require__(__webpack_require__.s = moduleId) }

crates/rspack/tests/tree-shaking/rollup-unused-called-import/snapshot/new_treeshaking.snap

@@ -6,9 +6,6 @@ source: crates/rspack_testing/src/run_fixture.rs
 "./dead.js": function (__unused_webpack_module, __webpack_exports__, __webpack_require__) {
 'use strict';
 __webpack_require__.r(__webpack_exports__);
-__webpack_require__.d(__webpack_exports__, {
-  'default': function() { return __WEBPACK_DEFAULT_EXPORT__; }
-});
 function __WEBPACK_DEFAULT_EXPORT__(){
     return "dead";
 }
@@ -25,7 +22,7 @@ function __WEBPACK_DEFAULT_EXPORT__(){
     return "foo";
 }
  function foodead() {
-    return "foo" + (0, _dead__WEBPACK_IMPORTED_MODULE_0_["default"])();
+    return "foo" + dead();
 }
 },
 "./index.js": function (__unused_webpack_module, __webpack_exports__, __webpack_require__) {

crates/rspack/tests/tree-shaking/rollup-unused-called-import/snapshot/snap.diff

@@ -1,21 +1,11 @@
 --- expected
 +++ actual
-@@ -6,6 +6,9 @@
- "./dead.js": function (__unused_webpack_module, __webpack_exports__, __webpack_require__) {
- 'use strict';
- __webpack_require__.r(__webpack_exports__);
-+__webpack_require__.d(__webpack_exports__, {
-+  'default': function() { return __WEBPACK_DEFAULT_EXPORT__; }
-+});
- function __WEBPACK_DEFAULT_EXPORT__(){
-     return "dead";
- }
-@@ -22,7 +25,7 @@
+@@ -22,7 +22,7 @@
      return "foo";
  }
   function foodead() {
 -    return "foo" + /* "./dead" unused */null();
-+    return "foo" + (0, _dead__WEBPACK_IMPORTED_MODULE_0_["default"])();
++    return "foo" + dead();
  }
  },
  "./index.js": function (__unused_webpack_module, __webpack_exports__, __webpack_require__) {