Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(angular_example): updating the example to include now working options #3302

Merged
merged 1 commit into from
May 25, 2023

Conversation

zackarychapple
Copy link
Contributor

@zackarychapple zackarychapple commented May 25, 2023

Several hooks needed for Angular have been added. This PR updates the example that we have to leverage the now available hooks / added compatibility.

Related issue (if exists)

Related to #3158

Summary

As contributors are making updates we need to keep the examples up to date to reflect current reality.

🤖 Generated by Copilot at 354e2e9

This file updates the rspack configuration for the Angular example to enhance the webpack bundling and caching process. It applies a plugin to avoid module duplication, adjusts the output settings for speed and uniqueness, and fine-tunes the async cache group enforcement.

Walkthrough

🤖 Generated by Copilot at 354e2e9

  • Enable and add DedupeModuleResolvePlugin to avoid duplicate modules and improve bundle performance and size (link, link)
  • Change output configuration to use faster hashing, avoid name conflicts, and specify output directory (link)
  • Force new chunk creation for defaultAsync cache group to optimize async loading and reduce initial bundle size (link)
  • Add empty line for readability (link)

@hardfist hardfist added this pull request to the merge queue May 25, 2023
Merged via the queue into web-infra-dev:main with commit 7bc610a May 25, 2023
@zackarychapple zackarychapple deleted the angular_may_update_2 branch May 31, 2023 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants