Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: enable more lints clippy rules #7589

Closed
hardfist opened this issue Aug 15, 2024 · 2 comments
Closed

refactor: enable more lints clippy rules #7589

hardfist opened this issue Aug 15, 2024 · 2 comments
Labels
team The issue/pr is created by the member of Rspack.

Comments

@hardfist
Copy link
Contributor

currently we only enable a very small sets of lint rules and clippy actually provides lots of rules that's not only useful for style but also for performance, we should adopt more clippy rule.
a good start is to learn from biome's rules https://github.com/biomejs/biome/blob/main/Cargo.toml#L15
@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Aug 15, 2024
@shulaoda
Copy link
Collaborator

Clippy lints: https://rust-lang.github.io/rust-clippy/rust-1.80.0/index.html

@hardfist hardfist mentioned this issue Aug 16, 2024
Merged
2 tasks
@h-a-n-a
Copy link
Contributor

h-a-n-a commented Aug 22, 2024

closed as finished

@h-a-n-a h-a-n-a closed this as completed Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
team The issue/pr is created by the member of Rspack.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@hardfist @h-a-n-a @shulaoda