Skip to content

Commit

Permalink
chore: release force use github runner (#7038)
Browse files Browse the repository at this point in the history
  • Loading branch information
jerrykingxyz authored Jul 4, 2024
1 parent 876964d commit fca07da
Show file tree
Hide file tree
Showing 4 changed files with 31 additions and 4 deletions.
29 changes: 25 additions & 4 deletions .github/workflows/get-runner-labels.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,12 @@ name: Get Runner Labels

on:
workflow_call:
inputs:
force-use-github-runner:
type: boolean
description: "Force use github runner"
required: false
default: false
outputs:
LINUX_RUNNER_LABELS:
description: "linux runner labels"
Expand All @@ -25,7 +31,22 @@ jobs:
- id: run
shell: bash
run: |
# set default value for vars.XXX_RUNNER_LABELS
echo 'LINUX_RUNNER_LABELS=${{ vars.LINUX_RUNNER_LABELS || '"ubuntu-latest"' }}' >> "$GITHUB_OUTPUT"
echo 'MACOS_RUNNER_LABELS=${{ vars.MACOS_RUNNER_LABELS || '"macos-latest"' }}' >> "$GITHUB_OUTPUT"
echo 'WINDOWS_RUNNER_LABELS=${{ vars.WINDOWS_RUNNER_LABELS || '"windows-latest"' }}' >> "$GITHUB_OUTPUT"
if ${{ !inputs.force-use-github-runner }}; then
LINUX_RUNNER_LABELS='${{ vars.LINUX_RUNNER_LABELS }}';
MACOS_RUNNER_LABELS='${{ vars.MACOS_RUNNER_LABELS }}';
WINDOWS_RUNNER_LABELS='${{ vars.WINDOWS_RUNNER_LABELS }}';
fi
# set default value
if [[ -z "$LINUX_RUNNER_LABELS" ]]; then
LINUX_RUNNER_LABELS='"ubuntu-latest"';
fi
if [[ -z "$MACOS_RUNNER_LABELS" ]]; then
MACOS_RUNNER_LABELS='"macos-latest"';
fi
if [[ -z "$WINDOWS_RUNNER_LABELS" ]]; then
WINDOWS_RUNNER_LABELS='"windows-latest"';
fi
# set output
echo "LINUX_RUNNER_LABELS=$LINUX_RUNNER_LABELS" >> "$GITHUB_OUTPUT"
echo "MACOS_RUNNER_LABELS=$MACOS_RUNNER_LABELS" >> "$GITHUB_OUTPUT"
echo "WINDOWS_RUNNER_LABELS=$WINDOWS_RUNNER_LABELS" >> "$GITHUB_OUTPUT"
2 changes: 2 additions & 0 deletions .github/workflows/release-canary.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@ jobs:
get-runner-labels:
name: Get Runner Labels
uses: ./.github/workflows/get-runner-labels.yml
with:
force-use-github-runner: true

build:
name: Build Canary
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/release-nightly.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@ jobs:
name: Get Runner Labels
if: github.repository_owner == 'web-infra-dev'
uses: ./.github/workflows/get-runner-labels.yml
with:
force-use-github-runner: true

build:
name: Build Nightly
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,8 @@ jobs:
get-runner-labels:
name: Get Runner Labels
uses: ./.github/workflows/get-runner-labels.yml
with:
force-use-github-runner: true

build:
needs: [get-runner-labels]
Expand Down

2 comments on commit fca07da

@rspack-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 Benchmark detail: Open

Name Base (2024-07-04 b05f523) Current Change
10000_development-mode + exec 2.14 s ± 20 ms 2.15 s ± 23 ms +0.79 %
10000_development-mode_hmr + exec 689 ms ± 5.8 ms 694 ms ± 3.7 ms +0.71 %
10000_production-mode + exec 2.76 s ± 25 ms 2.78 s ± 17 ms +0.64 %
arco-pro_development-mode + exec 1.89 s ± 57 ms 1.89 s ± 74 ms -0.27 %
arco-pro_development-mode_hmr + exec 432 ms ± 2 ms 434 ms ± 1.7 ms +0.32 %
arco-pro_production-mode + exec 3.48 s ± 84 ms 3.44 s ± 98 ms -1.03 %
threejs_development-mode_10x + exec 1.6 s ± 15 ms 1.57 s ± 9.7 ms -1.77 %
threejs_development-mode_10x_hmr + exec 820 ms ± 8.5 ms 800 ms ± 6 ms -2.52 %
threejs_production-mode_10x + exec 5.58 s ± 47 ms 5.59 s ± 36 ms +0.11 %

@rspack-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 Ran ecosystem CI: Open

suite result
modernjs ❌ failure
_selftest ✅ success
nx ✅ success
rspress ✅ success
rsbuild ❌ failure
compat ✅ success
examples ✅ success

Please sign in to comment.