Skip to content

Commit

Permalink
ci: linux-musl build failed (#8743)
Browse files Browse the repository at this point in the history
* fix: linux-musl release build failed

* fix: comment
  • Loading branch information
jerrykingxyz authored Dec 17, 2024
1 parent 88bd31b commit fbe97be
Showing 1 changed file with 13 additions and 1 deletion.
14 changes: 13 additions & 1 deletion .github/workflows/reusable-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,8 @@ jobs:
target: ${{ inputs.target }}
image: ghcr.io/napi-rs/napi-rs/nodejs-rust:lts-debian-aarch64
profile: ${{ inputs.profile }}
pre: export CC_aarch64_unknown_linux_gnu=clang
pre: |
export CC_aarch64_unknown_linux_gnu=clang
- name: Build x86_64-unknown-linux-musl in Docker
if: ${{ inputs.target == 'x86_64-unknown-linux-musl' && steps.check_cache.outputs.files_exists != 'true' && !inputs.skipable }}
Expand All @@ -157,6 +158,12 @@ jobs:
target: ${{ inputs.target }}
image: ghcr.io/napi-rs/napi-rs/nodejs-rust:lts-alpine
profile: ${{ inputs.profile }}
pre: |
# musl will enable clang-sys static linking
# https://github.com/KyleMayes/clang-sys?tab=readme-ov-file#static
# llvm19-dev is used to install llvm-config
# clang19-static is used to install libclang.a
apk add llvm19-dev clang19-static
- name: Build aarch64-unknown-linux-musl in Docker
if: ${{ inputs.target == 'aarch64-unknown-linux-musl' && steps.check_cache.outputs.files_exists != 'true' && !inputs.skipable }}
Expand All @@ -167,6 +174,11 @@ jobs:
profile: ${{ inputs.profile }}
pre: |
export CARGO_TARGET_AARCH64_UNKNOWN_LINUX_MUSL_LINKER=aarch64-linux-musl-gcc
# musl will enable clang-sys static linking
# https://github.com/KyleMayes/clang-sys?tab=readme-ov-file#static
# llvm19-dev is used to install llvm-config
# clang19-static is used to install libclang.a
apk add llvm19-dev clang19-static
# setup rust target for windows and macos
- name: Setup Rust Target
Expand Down

2 comments on commit fbe97be

@rspack-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 Ran ecosystem CI: Open

suite result
modernjs ❌ failure
_selftest ✅ success
rsdoctor ❌ failure
rspress ✅ success
rslib ✅ success
rsbuild ❌ failure
examples ❌ failure
devserver ✅ success
nuxt ✅ success

@rspack-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 Benchmark detail: Open

Name Base (2024-12-17 fb2869d) Current Change
10000_big_production-mode_disable-minimize + exec 37.9 s ± 622 ms 38.1 s ± 609 ms +0.43 %
10000_development-mode + exec 1.87 s ± 24 ms 1.83 s ± 24 ms -2.33 %
10000_development-mode_hmr + exec 687 ms ± 28 ms 670 ms ± 8.4 ms -2.49 %
10000_production-mode + exec 2.47 s ± 48 ms 2.37 s ± 30 ms -4.09 %
arco-pro_development-mode + exec 1.77 s ± 90 ms 1.77 s ± 77 ms +0.36 %
arco-pro_development-mode_hmr + exec 379 ms ± 1.6 ms 378 ms ± 1.5 ms -0.38 %
arco-pro_production-mode + exec 3.31 s ± 75 ms 3.24 s ± 91 ms -2.18 %
arco-pro_production-mode_generate-package-json-webpack-plugin + exec 3.37 s ± 152 ms 3.33 s ± 63 ms -1.15 %
arco-pro_production-mode_traverse-chunk-modules + exec 3.34 s ± 124 ms 3.3 s ± 109 ms -1.26 %
threejs_development-mode_10x + exec 1.61 s ± 20 ms 1.62 s ± 17 ms +0.92 %
threejs_development-mode_10x_hmr + exec 794 ms ± 28 ms 808 ms ± 13 ms +1.78 %
threejs_production-mode_10x + exec 5.42 s ± 141 ms 5.32 s ± 51 ms -1.75 %
10000_big_production-mode_disable-minimize + rss memory 9482 MiB ± 276 MiB 9492 MiB ± 124 MiB +0.10 %
10000_development-mode + rss memory 633 MiB ± 14.8 MiB 726 MiB ± 22.3 MiB +14.61 %
10000_development-mode_hmr + rss memory 1396 MiB ± 296 MiB 1483 MiB ± 350 MiB +6.22 %
10000_production-mode + rss memory 601 MiB ± 31.9 MiB 708 MiB ± 32.4 MiB +17.85 %
arco-pro_development-mode + rss memory 587 MiB ± 40.3 MiB 634 MiB ± 39 MiB +7.97 %
arco-pro_development-mode_hmr + rss memory 639 MiB ± 102 MiB 655 MiB ± 87.8 MiB +2.42 %
arco-pro_production-mode + rss memory 742 MiB ± 50.5 MiB 764 MiB ± 63.6 MiB +3.01 %
arco-pro_production-mode_generate-package-json-webpack-plugin + rss memory 737 MiB ± 45.5 MiB 791 MiB ± 39.3 MiB +7.45 %
arco-pro_production-mode_traverse-chunk-modules + rss memory 720 MiB ± 58.3 MiB 779 MiB ± 46.3 MiB +8.15 %
threejs_development-mode_10x + rss memory 638 MiB ± 22.2 MiB 715 MiB ± 53.7 MiB +12.12 %
threejs_development-mode_10x_hmr + rss memory 1194 MiB ± 248 MiB 1248 MiB ± 206 MiB +4.46 %
threejs_production-mode_10x + rss memory 948 MiB ± 55 MiB 941 MiB ± 67.6 MiB -0.80 %

Please sign in to comment.